This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Implement hide-autofill-popup #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix brave#3816 fix brave#4540 fix brave#5023 Auditors: @bbondy Test Plan: 1. Go to https://github.com/brave/browser-laptop/issues 2. In the filters textbox, start typing characters until autocomplete pops up 3. Push enter to submit 4. Scroll the page should dismiss the popup 1. Go to https://github.com/brave/browser-laptop/issues 2. In the filters textbox, start typing characters until autocomplete pops up 3. Push enter to submit 4. Popup should be dismissed
|
++ |
|
❤️ |
This was referenced Nov 10, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).fix #3816
fix #4540
fix #5023
Auditors: @bbondy
Test Plan:
Go to https://github.com/brave/browser-laptop/issues
In the filters textbox, start typing characters until autocomplete pops up
Push enter to submit
Scroll the page should dismiss the popup
Go to https://github.com/brave/browser-laptop/issues
In the filters textbox, start typing characters until autocomplete pops up
Push enter to submit
Popup should be dismissed