Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Context Menus are Visible While Scrolling #5023

Closed
jonathansampson opened this issue Oct 21, 2016 · 2 comments · Fixed by #5287
Closed

Context Menus are Visible While Scrolling #5023

jonathansampson opened this issue Oct 21, 2016 · 2 comments · Fixed by #5287
Assignees
@darkdh
Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 21, 2016 •
edited
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Context menus are visible while scrolling.

Expected behavior:
Context menus should be hidden upon scrolling.

Screenshot:
contextmenuscroll

Resolution Process:
Originally reported to me by @jaydson. If/when this issue is resolved, we should notify Jaydson.
@srirambv
Copy link
Collaborator

It's also visible when you hover over a different tab and the tab preview is shown

image

@jaydson
Copy link

jaydson commented Oct 23, 2016

UPDATE: This behaviour also happen when you are at PAGE1 with the context menu visible, then you hit enter and navigate to PAGE2.

PAGE1:
brave-context-1

PAGE2 LOADING:
brave-context-2

PAGE2:
brave-context-3

@darkdh darkdh self-assigned this Oct 31, 2016
@darkdh darkdh modified the milestones: 1.0.0, 0.12.9dev Oct 31, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 31, 2016
@darkdh
Implement hide-autofill-popup
68d8db6 
fix brave#3816
fix brave#4540
fix brave#5023

Auditors: @bbondy

Test Plan:
1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Scroll the page should dismiss the popup

1. Go to https://github.com/brave/browser-laptop/issues
2. In the filters textbox, start typing characters until autocomplete pops up
3. Push enter to submit
4. Popup should be dismissed
@darkdh darkdh mentioned this issue Oct 31, 2016
Merged
4 tasks
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/autofill QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

Implement hide-autofill-popup darkdh/browser-laptop
6 participants
@jaydson @jonathansampson @alexwykoff @luixxiul @darkdh @srirambv