This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Refactored history, bookmarks, sortableTable, and about with Aphrodite #13590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored history, bookmarks, sortableTable, and about with Aphrodite
Fixes and/or applies to issue #10880, issue #10898, issue #10899, issue #8056
Also applies to #8587 and eliminates the need for history.less
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests
Request review @luixxiul @bsclifton
Request security review @diracdeltas
There are 'hacks' that do exist due to aphrodite being a component styler and not necessarily a 'selector styler'. Please advise on any requested changes.
If these changes are acceptable, 'history.less' can be removed. 'sortableTable.less' still has trivial links.