This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor js/about/bookmarks.js with Aphrodite #10898
Assignees
Comments
This was referenced Sep 11, 2017
Merged
This was referenced Sep 20, 2017
8 tasks
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Fixes brave#11201 Only BrowserButton with 'fitContent' props are forced to have the min-width:fit-content. This change is required to apply display:flex to headerActions, as it refers width instead of min-width, even though actual min-width is larger than actual width of the buttons. - Align header items on about:history (fixes brave#10465) - Polish .searchInput on about:bookmarks and about:history (addresses brave#10898 and brave#10899) Auditors: @cezaraugusto Test Plan: 1. Open about:history 2. Open about:bookmarks 3. Make sure the header items are not wrapped Test Plan 2: 1. Open https://expired.badssl.com/ 2. Minimize the window's width 3. Make sure the buttons' text do not overflow
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
See
6th commitof #10951 (comment)Describe the issue you encountered: Refactor
js/about/bookmarks.jswith AphroditeExtra QA steps:
1.
2.
3.
Any related issues:
The text was updated successfully, but these errors were encountered: