This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
display:flex ignores actual width of the buttons #11201
Assignees
Labels
Milestone
Comments
8 tasks
luixxiul
changed the title
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Fixes brave#11201 Only BrowserButton with 'fitContent' props are forced to have the min-width:fit-content. This change is required to apply display:flex to headerActions, as it refers width instead of min-width, even though actual min-width is larger than actual width of the buttons. - Align header items on about:history (fixes brave#10465) - Polish .searchInput on about:bookmarks and about:history (addresses brave#10898 and brave#10899) Auditors: @cezaraugusto Test Plan: 1. Open about:history 2. Open about:bookmarks 3. Make sure the header items are not wrapped Test Plan 2: 1. Open https://expired.badssl.com/ 2. Minimize the window's width 3. Make sure the buttons' text do not overflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#11202 (comment)
Description
display:flex ignores actual width of the buttons.
See the feedback comment by @srirambv on #10951 (review).
When you have elements which have both
widthandmin-widthspecified withfit-content, which is actually larger than the fixedwidth, and the elements are placed withdisplay: flexordisplay: grid, the elements overwrap each other because the preferred value iswidth, notmin-width.I personally believe it should be a bug of specification or implementation, though.
Steps to Reproduce
Actual result:
The button and the search form overwrap each other.
Expected result:
They should not overwrap each other.
Reproduces how often: [What percentage of the time does it reproduce?]
Brave Version
about:brave info:
0.21. The bug was introduced with #10934
Reproducible on current live release:
No.
Additional Information
The text was updated successfully, but these errors were encountered: