Final browser-laptop update #15309

bsclifton · 2018-10-26T18:57:19Z

The final update for browser-laptop

Test plan

diracdeltas · 2018-10-30T19:30:32Z

@bsclifton per discussion in slack, i would like to add some messaging/UI in this to help Linux users transition to the new repos (and also this should wait for https://github.com/brave/devops/issues/361).

app/updater.js

diracdeltas · 2018-11-06T20:03:14Z

app/updater.js

+        options: {
+          persist: false,
+          advancedText: 'See instructions to upgrade to the latest version',
+          advancedLink: 'https://brave-browser.readthedocs.io/en/latest/installing-brave.html#linux'


This is blocked on the doc text being updated with the new signing keys: brave/brave-browser#1826

diracdeltas · 2018-11-06T23:06:12Z

looks fine when i pretended my mac was linux to trigger the notification, except kind of incongruous that the token grant notification also pops up:

we probably want to either suppress it or prevent the old brave wallets from having any funds added to them?

diracdeltas · 2018-11-06T23:14:07Z

On Mac, the message looks great but I don't think the auto-install of b-c actually worked. I see this in the console:

Extracting brave-core binaries from "/Users/yan/repos/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/Brave-Browser.pkg" into temp directory "/var/folders/hl/761qjwzn4qb7slh2yvlgwfxr0000gn/T/brave-upgrade"
Could not open product archive: /Users/yan/repos/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/Brave-Browser.pkg
Removing temp directory "/var/folders/hl/761qjwzn4qb7slh2yvlgwfxr0000gn/T/brave-upgrade"

diracdeltas · 2018-11-06T23:15:25Z

/Users/yan/repos/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/Brave-Browser.pkg does not exist btw

@diracdeltas

per feedback in #15309 (comment) Auditors: @diracdeltas

bsclifton · 2018-11-06T23:18:00Z

@diracdeltas for the auto-install to work, you have to run packaging; I'm about to queue a build for Nightly channel if you're interested in trying it out? 😄

@diracdeltas

per feedback in #15309 (comment) Auditors: @diracdeltas

… stub executable. Fixes brave/brave-browser#1540 Fixes brave/brave-browser#1782 - Stub executable detects brave-core and will launch it (instead of browser-laptop) - Friendly name of app (as shown in Add/Remove programs and Default app settings) to `Brave (old)` - Dependencies updated

Fixes brave/brave-browser#1541 Fixes brave/brave-browser#1543

- install is done last (after possible relaunch due to missing args) - install is working good; however it's opening brave-core after the silent install Forcibly create desktop shortcut as a work-around for problems with electron-squirrel-startup Fixes brave/brave-browser#1867

bsclifton · 2018-12-06T04:09:00Z

@diracdeltas feedback addressed in 3f06a99 😄

app/windowsInit.js

tools/buildPackage.js

petemill

lgtm! ⚔️ ⚰️
Only shame is having ~200mb of binary files added to this Git repo, which would mean anyone who performs a fetch would have that forever in their .git folder. As this repo is soon to be archived, I'm sure that's not a big deal. If it was we could download from a remote location during packaging. If anyone every forks this repo for continued development then they can strip git's history if they like!

0.25.202 0.25.203 0.25.204 0.25.205 0.25.206 0.25.207 0.25.208 0.25.209 0.25.210 0.25.211 0.25.212 0.25.213 0.25.214 0.25.215 0.25.216 0.25.217

…ate on Windows (nightly channel)

removed from brave-core with brave/brave-browser#2047

Usage: `BUNDLE_NAME="My\ App" CHANNEL=nightly npm run build-package`

- deprecation notice shown - you can restore already existing groups (so that you can clear, if you'd like) - existing sync groups will show and can be cleared

I believe this was causing a crash during end-to-end testing

petemill

Re-approving due to new binaries and version bump

Farewell browser-laptop!

bsclifton added the PR/work-in-progress ⚒ label Oct 26, 2018

bsclifton self-assigned this Oct 26, 2018

This was referenced Oct 26, 2018

Document the Muon upgrade path brave/brave-browser#1863

Closed

Updated to generate duplicate desktop (used for old browser-laptop) brave/electron-squirrel-startup#5

Closed

diracdeltas self-requested a review October 30, 2018 19:30

diracdeltas self-assigned this Oct 30, 2018

bsclifton force-pushed the muon-upgrade-windows branch 3 times, most recently from e50e008 to 162b040 Compare November 2, 2018 06:06

diracdeltas reviewed Nov 6, 2018

View reviewed changes

app/updater.js Outdated Show resolved Hide resolved

diracdeltas reviewed Nov 6, 2018

View reviewed changes

bsclifton force-pushed the muon-upgrade-windows branch from f1a319f to 3321007 Compare November 6, 2018 20:06

bsclifton added a commit that referenced this pull request Nov 6, 2018

Always show the notification bar

825a37a

per feedback in #15309 (comment) Auditors: @diracdeltas

bsclifton force-pushed the muon-upgrade-windows branch from 0721d3b to cb5c0fb Compare November 7, 2018 05:07

bsclifton added a commit that referenced this pull request Nov 7, 2018

Always show the notification bar

bb15223

per feedback in #15309 (comment) Auditors: @diracdeltas

bsclifton force-pushed the muon-upgrade-windows branch from cb5c0fb to db32bcd Compare November 7, 2018 05:38

bsclifton added 4 commits November 6, 2018 22:47

Automate brave-core install for macOS

3cbd41c

Fixes brave/brave-browser#1541 Fixes brave/brave-browser#1543

Update icons. Fixes brave/brave-browser#1915

93fa3b4

bsclifton force-pushed the muon-upgrade-windows branch 2 times, most recently from ebf7321 to 12b1b7e Compare November 7, 2018 06:26

bsclifton requested review from darkdh, NejcZdovc and aekeus November 7, 2018 06:27

bsclifton force-pushed the muon-upgrade-windows branch 4 times, most recently from 5af0fee to 3f06a99 Compare December 6, 2018 04:07

petemill reviewed Dec 6, 2018

View reviewed changes

app/windowsInit.js Show resolved Hide resolved

petemill reviewed Dec 6, 2018

View reviewed changes

tools/buildPackage.js Show resolved Hide resolved

petemill previously approved these changes Dec 6, 2018

View reviewed changes

bsclifton dismissed petemill’s stale review via 831b5ea December 7, 2018 07:38

bsclifton force-pushed the muon-upgrade-windows branch from 9e1f778 to 831b5ea Compare December 7, 2018 07:38

bsclifton and others added 12 commits December 7, 2018 08:17

Brave Core binaries

cbe282d

Paths for Brave Core binaries

f8e887c

Version bump

6b93f8e

0.25.202 0.25.203 0.25.204 0.25.205 0.25.206 0.25.207 0.25.208 0.25.209 0.25.210 0.25.211 0.25.212 0.25.213 0.25.214 0.25.215 0.25.216 0.25.217

Address review feedback

f381a3e

Updates StartPage branding

b0af328

Add debug logging, to make it easier to diagnose issues seen by teamm…

782bc3f

…ate on Windows (nightly channel)

Remove FindX search engine (I believe it's been EOLed). This was already

cf1d2b3

removed from brave-core with brave/brave-browser#2047

Allow packager to output a different CFBundleName for the macOS packager

09901ae

Usage: `BUNDLE_NAME="My\ App" CHANNEL=nightly npm run build-package`

Ran npm audit fix to bring vulnerabilities down from 23 to 14

28adf74

Disable sync

6c98eee

- deprecation notice shown - you can restore already existing groups (so that you can clear, if you'd like) - existing sync groups will show and can be cleared

review feedback

9b52daf

Remove default browser check (and set on launch).

f0be763

I believe this was causing a crash during end-to-end testing

bsclifton force-pushed the muon-upgrade-windows branch from 831b5ea to f0be763 Compare December 7, 2018 16:22

0.26.0

ef8f8dc

petemill approved these changes Dec 7, 2018

View reviewed changes

bsclifton merged commit de4ff2d into master Dec 7, 2018

bsclifton deleted the muon-upgrade-windows branch December 7, 2018 19:15

bsclifton added a commit that referenced this pull request Dec 10, 2018

Manual merge of the deprecation notice that was included in #15309

2556a88

diracdeltas mentioned this pull request Dec 17, 2018

Only display upgrade notification (don't perform auto-upgrade) #15334

Merged

10 tasks

bsclifton added a commit that referenced this pull request Dec 17, 2018

Manual merge of the deprecation notice that was included in #15309

23a8571

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final browser-laptop update #15309

Final browser-laptop update #15309

bsclifton commented Oct 26, 2018 •

edited

Loading

diracdeltas commented Oct 30, 2018

diracdeltas Nov 6, 2018

diracdeltas commented Nov 6, 2018

diracdeltas commented Nov 6, 2018

diracdeltas commented Nov 6, 2018

bsclifton commented Nov 6, 2018

bsclifton commented Dec 6, 2018

petemill left a comment

petemill left a comment

Final browser-laptop update #15309

Final browser-laptop update #15309

Conversation

bsclifton commented Oct 26, 2018 • edited Loading

Test plan

diracdeltas commented Oct 30, 2018

diracdeltas Nov 6, 2018

Choose a reason for hiding this comment

diracdeltas commented Nov 6, 2018

diracdeltas commented Nov 6, 2018

diracdeltas commented Nov 6, 2018

bsclifton commented Nov 6, 2018

bsclifton commented Dec 6, 2018

petemill left a comment

Choose a reason for hiding this comment

petemill left a comment

Choose a reason for hiding this comment

bsclifton commented Oct 26, 2018 •

edited

Loading