Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove top-level version from BOM #357

Closed
ekcasey opened this issue Jul 30, 2020 · 1 comment · Fixed by #367
Closed

Remove top-level version from BOM #357

ekcasey opened this issue Jul 30, 2020 · 1 comment · Fixed by #367
Assignees
@yaelharel
Milestone
lifecycle-0.9.0

Comments

@ekcasey
Copy link
Member

ekcasey commented Jul 30, 2020 •
edited
Loading

RFC 0043
RFC PR: buildpacks/rfcs#82
Spec PR: buildpacks/spec#117
Spec Issue: buildpacks/spec#107

Behavior

If platform API is 0.3 Bill-of-Materials entries should include a top-level version key and any metadata.version fields should be converted to version
If platform API is 0.4 Bill-of-Materials entries should not include a top-level version key and version provided by the buildpack should be converted to metadata.version
@ekcasey ekcasey added this to the lifecycle-0.9.0 milestone Jul 30, 2020
yaelharel pushed a commit to yaelharel/lifecycle that referenced this issue Aug 5, 2020
Remove top-level version from BOM
3ac2eda 
resolves: buildpacks#357

Signed-off-by: Yael Harel <yharel@vmware.com>
@yaelharel yaelharel mentioned this issue Aug 5, 2020
Merged
ekcasey pushed a commit that referenced this issue Aug 7, 2020
@ekcasey
Remove top-level version from BOM
5f981ea 
resolves: #357

Signed-off-by: Yael Harel <yharel@vmware.com>
@ekcasey
Copy link
Member Author

ekcasey commented Aug 8, 2020

Updated requirements to preserve metadata.version in the platform 0.3 BOM. Some buildpacks are already using metadata.version with platform API 0.3 and we should not remove keys that are currently used/expected.

@ekcasey ekcasey mentioned this issue Aug 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaelharel yaelharel

Labels
None yet
Projects
None yet
Milestone
lifecycle-0.9.0
Development

Successfully merging a pull request may close this issue.

Remove top-level version from BOM yaelharel/lifecycle
2 participants
@ekcasey @yaelharel