Delete most of abi from wit-parser
#1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deletes most of the `abi` module from the `wit-parser` crate. This functionality is entirely untested in this repository and was originally intended for `wit-bindgen`-style generators. In thinking about bytecodealliance/wit-bindgen#622 I'm going to want to make some invasive changes to this and I'd rather develop everything close to the source rather than across two repositories. My plan is to move all this code upstream into the `wit-bindgen-core` crate in the `wit-bindgen` repository. Which is to say this is the first half of moving the code, deleting the source here, and I'll make a follow-up PR to re-add all this code into `wit-bindgen-core` so all current consumers will continue to work and/or can switch to depending on `wit-bindgen-core` to preserve the functionality.
alexcrichton
added a commit
to alexcrichton/wit-bindgen
that referenced
this pull request
Aug 7, 2023
This commit is the dual of bytecodealliance/wasm-tools#1149 where the code is being moved from the `wit-parser` crate into this repository where it's mainly developed. This commit adds a `wit_bindgen_core::abi` module with the same contents as before with small refactorings to avoid inherent methods on `Resolve`. Note that this temporarily switches to a git dependency for the wasm-tools family of crates which will be reverted back to a crates.io dependency one they're published.
alexcrichton
added a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Aug 18, 2023
* Remove reliance on `wit_parser::abi` This commit is the dual of bytecodealliance/wasm-tools#1149 where the code is being moved from the `wit-parser` crate into this repository where it's mainly developed. This commit adds a `wit_bindgen_core::abi` module with the same contents as before with small refactorings to avoid inherent methods on `Resolve`. Note that this temporarily switches to a git dependency for the wasm-tools family of crates which will be reverted back to a crates.io dependency one they're published. * Update dependencies to `main`
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Aug 18, 2023
Release latest changes such as: * `wasm-tools compose` now supports `-t` (bytecodealliance#1148) * The `abi` module is removed from the `wit-parser` crate (bytecodealliance#1149, bytecodealliance#1159) * Fix validation of lowered functions in the component model (bytecodealliance#1150) * Fix a panic decoding WIT from a component (bytecodealliance#1157) * Add text format and printing support for `dylink.0` (bytecodealliance#1135) * Support shared-everything linking in `wasm-tools component new` (bytecodealliance#1133) * Printing a WIT document now prints comments as well (bytecodealliance#1167) * Disallow `(borrow $t)` in component function results (bytecodealliance#1162)
Merged
peterhuene
pushed a commit
that referenced
this pull request
Aug 18, 2023
Release latest changes such as: * `wasm-tools compose` now supports `-t` (#1148) * The `abi` module is removed from the `wit-parser` crate (#1149, #1159) * Fix validation of lowered functions in the component model (#1150) * Fix a panic decoding WIT from a component (#1157) * Add text format and printing support for `dylink.0` (#1135) * Support shared-everything linking in `wasm-tools component new` (#1133) * Printing a WIT document now prints comments as well (#1167) * Disallow `(borrow $t)` in component function results (#1162)
rvolosatovs
pushed a commit
to bytecodealliance/wrpc
that referenced
this pull request
May 23, 2024
* Remove reliance on `wit_parser::abi` This commit is the dual of bytecodealliance/wasm-tools#1149 where the code is being moved from the `wit-parser` crate into this repository where it's mainly developed. This commit adds a `wit_bindgen_core::abi` module with the same contents as before with small refactorings to avoid inherent methods on `Resolve`. Note that this temporarily switches to a git dependency for the wasm-tools family of crates which will be reverted back to a crates.io dependency one they're published. * Update dependencies to `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deletes most of the
abimodule from thewit-parsercrate. This functionality is entirely untested in this repository and was originally intended forwit-bindgen-style generators. In thinking about bytecodealliance/wit-bindgen#622 I'm going to want to make some invasive changes to this and I'd rather develop everything close to the source rather than across two repositories.My plan is to move all this code upstream into the
wit-bindgen-corecrate in thewit-bindgenrepository. Which is to say this is the first half of moving the code, deleting the source here, and I'll make a follow-up PR to re-add all this code intowit-bindgen-coreso all current consumers will continue to work and/or can switch to depending onwit-bindgen-coreto preserve the functionality.