Probe for post-return instead of asserting existence #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Aug 7, 2023
alexcrichton
force-pushed
the
probe-for-post-return
branch
from
b1f3970 to
8894db2
Compare
This commit updates `wit-component` to probe for the existence of post-return functions rather than asserting their existence. This enables moves some more ABI bits to `wit-bindgen-core` since they otherwise don't quite make sense here. This additionally fixes a longstanding issue with `wit-component`, although it's not one that's actually come up in practice yet.
alexcrichton
force-pushed
the
probe-for-post-return
branch
from
8894db2 to
1899fc6
Compare
dicej
approved these changes
Aug 10, 2023
| func: &Function, | ||
| ) -> Result<()> { | ||
| let mut sig = resolve.wasm_signature(AbiVariant::GuestExport, func); | ||
| sig.params = mem::take(&mut sig.results); |
Collaborator
There was a problem hiding this comment.
A comment here might be helpful -- took me a minute to realize this was because the parameters to a post-return function should match the results of the primary function.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Aug 18, 2023
Release latest changes such as: * `wasm-tools compose` now supports `-t` (bytecodealliance#1148) * The `abi` module is removed from the `wit-parser` crate (bytecodealliance#1149, bytecodealliance#1159) * Fix validation of lowered functions in the component model (bytecodealliance#1150) * Fix a panic decoding WIT from a component (bytecodealliance#1157) * Add text format and printing support for `dylink.0` (bytecodealliance#1135) * Support shared-everything linking in `wasm-tools component new` (bytecodealliance#1133) * Printing a WIT document now prints comments as well (bytecodealliance#1167) * Disallow `(borrow $t)` in component function results (bytecodealliance#1162)
Merged
peterhuene
pushed a commit
that referenced
this pull request
Aug 18, 2023
Release latest changes such as: * `wasm-tools compose` now supports `-t` (#1148) * The `abi` module is removed from the `wit-parser` crate (#1149, #1159) * Fix validation of lowered functions in the component model (#1150) * Fix a panic decoding WIT from a component (#1157) * Add text format and printing support for `dylink.0` (#1135) * Support shared-everything linking in `wasm-tools component new` (#1133) * Printing a WIT document now prints comments as well (#1167) * Disallow `(borrow $t)` in component function results (#1162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
wit-componentto probe for the existence of post-return functions rather than asserting their existence. This enables moves some more ABI bits towit-bindgen-coresince they otherwise don't quite make sense here. This additionally fixes a longstanding issue withwit-component, although it's not one that's actually come up in practice yet.