Fix a panic decoding WIT from a component #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a fuzz-found issue where the WIT inference process from a concrete component could panic. The underlying issue is detailed within the comments of the code in this commit, but the effective fix applied here is to remove the assertion and revisit it later if necessary.
sunfishcode
approved these changes
Aug 8, 2023
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Aug 18, 2023
Release latest changes such as: * `wasm-tools compose` now supports `-t` (bytecodealliance#1148) * The `abi` module is removed from the `wit-parser` crate (bytecodealliance#1149, bytecodealliance#1159) * Fix validation of lowered functions in the component model (bytecodealliance#1150) * Fix a panic decoding WIT from a component (bytecodealliance#1157) * Add text format and printing support for `dylink.0` (bytecodealliance#1135) * Support shared-everything linking in `wasm-tools component new` (bytecodealliance#1133) * Printing a WIT document now prints comments as well (bytecodealliance#1167) * Disallow `(borrow $t)` in component function results (bytecodealliance#1162)
Merged
peterhuene
pushed a commit
that referenced
this pull request
Aug 18, 2023
Release latest changes such as: * `wasm-tools compose` now supports `-t` (#1148) * The `abi` module is removed from the `wit-parser` crate (#1149, #1159) * Fix validation of lowered functions in the component model (#1150) * Fix a panic decoding WIT from a component (#1157) * Add text format and printing support for `dylink.0` (#1135) * Support shared-everything linking in `wasm-tools component new` (#1133) * Printing a WIT document now prints comments as well (#1167) * Disallow `(borrow $t)` in component function results (#1162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a fuzz-found issue where the WIT inference process from a concrete component could panic. The underlying issue is detailed within the comments of the code in this commit, but the effective fix applied here is to remove the assertion and revisit it later if necessary.