Remove the whitespace in the join for the kube-downscaler ConfigMap Helm template. #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #26
Motivation
To fix #26
Changes
Simply removing the trailing white-space in the
Helm join()
in thekube-downscaler
ConfigMap Helm Template
file. The white-space makes namespace exclusions go haywire. This is, at least as far as I can interpret, because of LOC78 in main.py. Where thePython re lib
is used. It also splits the string, andsplit(",")
seems NOT to work with entries being e.g.:namespacea, namespaceb, namespacec
and so on.Tests done
EXCLUDE_NAMESPACES
list in theConfigMap
. Simply removed every white-space after eachnamespace
.Kube-downscaler Pod
by deleting itE.g. in the log.
A line for each
namespace
to be excluded. This with thekube-downscaler
inDEBUG
mode.Thank you and of course ask and inquire me for more info if needed. However, I think this should be pretty clear.