Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the whitespace in the join for the kube-downscaler ConfigMap Helm template. #27

Closed
wants to merge 1 commit into from

Conversation

larssb
Copy link

@larssb larssb commented May 5, 2024

This fixes #26

Motivation

To fix #26


Changes

Simply removing the trailing white-space in the Helm join() in the kube-downscaler ConfigMap Helm Template file. The white-space makes namespace exclusions go haywire. This is, at least as far as I can interpret, because of LOC78 in main.py. Where the Python re lib is used. It also splits the string, and split(",") seems NOT to work with entries being e.g.: namespacea, namespaceb, namespacec and so on.

Tests done

  1. I manually edited the EXCLUDE_NAMESPACES list in the ConfigMap. Simply removed every white-space after each namespace.
  2. Restarted the Kube-downscaler Pod by deleting it
  3. Watched it work

E.g. in the log.

2024-05-05 20:40:52,762 DEBUG: Namespace haproxy-system was excluded (exclusion list regex matches)
....
....

A line for each namespace to be excluded. This with the kube-downscaler in DEBUG mode.

Thank you and of course ask and inquire me for more info if needed. However, I think this should be pretty clear.

@Fovty Fovty added the bug Something isn't working label May 7, 2024
Fovty
Fovty previously approved these changes May 7, 2024
Copy link
Member

@Fovty Fovty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fovty Fovty dismissed their stale review May 7, 2024 12:08

PR #25 already addresses the issue

@Fovty
Copy link
Member

Fovty commented May 7, 2024

@Fovty Fovty closed this May 7, 2024
@Fovty Fovty mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespaces declared to be excluded are not.
2 participants