Add ttl for sticky task list #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc-zz
reviewed
Jan 22, 2018
| return &LeaseTaskListResponse{TaskListInfo: tli}, nil | ||
| } | ||
|
|
||
| // From TaskManager interface | ||
| func (d *cassandraPersistence) UpdateTaskList(request *UpdateTaskListRequest) (*UpdateTaskListResponse, error) { | ||
| tli := request.TaskListInfo | ||
|
|
||
| if tli.Kind == TaskListKindWorker { // if task_list is sticky, then update with TTL | ||
| fmt.Println("vancexu in updateTaskList with TTL") |
There was a problem hiding this comment.
Done, Thanks for catching this.
common/persistence/dataInterfaces.go
Outdated
| // Kinds of task lists | ||
| const ( | ||
| TaskListKindNormal = iota | ||
| TaskListKindWorker |
| @@ -196,6 +196,11 @@ enum HistoryEventFilterType { | |||
| CLOSE_EVENT, | |||
| } | |||
|
|
|||
| enum TaskListKind { | |||
| NORMAL, | |||
| WORKER, | |||
schema/cadence/schema.cql
Outdated
| @@ -132,6 +132,7 @@ CREATE TYPE task_list ( | |||
| name text, | |||
| type int, -- enum TaskRowType {ActivityTask, DecisionTask} | |||
| ack_level bigint, -- task_id of the last acknowledged message | |||
| kind int, -- enum TaskListKind {Normal, Worker} | |||
There was a problem hiding this comment.
update comments after rename WORKER to STICKY
|
Manually test old client works, but in that case the tasklist will be treated as NORMAL all the time and wouldn't be removed automatically. |
yiminc-zz
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will delete sticky task list in one day after no ack update happens for that task list.
Relate issue: #472