Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update codemirror deps #4561

Closed
wants to merge 2 commits into from
Closed

deps: update codemirror deps #4561

wants to merge 2 commits into from

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Sep 26, 2024

Proposed Changes

This updates codemirror deps. Not sure why renovate does not pick this up.
We can merge it after the release.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac barmac requested review from a team, marstamm and abdul99ahad and removed request for a team September 26, 2024 11:42
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 26, 2024
@nikku nikku modified the milestones: M81, M82 Sep 26, 2024
@nikku
Copy link
Member

nikku commented Sep 26, 2024

develop is un-frozen, you can go ahead and review + merge.

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

This is not fixing #4559

@nikku
Copy link
Member

nikku commented Sep 26, 2024

I suggest a

 npm update --save @codemirror/language @codemirror/view @codemirror/autocomplete @codemirror/commands @codemirror/language @codemirror/lint @codemirror/state

Run to find more updates.

@nikku
Copy link
Member

nikku commented Sep 26, 2024

Pushed via dd71dfb.

@nikku
Copy link
Member

nikku commented Sep 26, 2024

To be handled with care and/or paused for the moment, cf. #4563 (comment).

@barmac
Copy link
Collaborator Author

barmac commented Sep 27, 2024

This needs to be merged together with #4487

@barmac
Copy link
Collaborator Author

barmac commented Sep 27, 2024

Closing this in favor of #4565

@barmac barmac closed this Sep 27, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants