Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: downgrade to form-js@1.10.0 #4563

Merged
merged 1 commit into from
Sep 26, 2024
Merged

deps: downgrade to form-js@1.10.0 #4563

merged 1 commit into from
Sep 26, 2024

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Sep 26, 2024

Proposed Changes

As we were not able to easily find the problem cause, this reverts commit 8f6662d.

Closes #4559

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

This reverts commit 8f6662d.

Closes #4559
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 26, 2024
@barmac barmac requested a review from nikku September 26, 2024 12:58
@barmac barmac mentioned this pull request Sep 26, 2024
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the fix, and also confirm that forms still work.

Good work.

@nikku nikku merged commit a15dc7c into main Sep 26, 2024
14 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 26, 2024
@nikku nikku deleted the 4559-revert-form-js branch September 26, 2024 13:37
@github-actions github-actions bot added this to the M81 milestone Sep 26, 2024
@nikku
Copy link
Member

nikku commented Sep 26, 2024

Confirmed this breaks with the codemirror updates that were pulled in via #4535. Steps to reproduce, from main:

npm update --save @codemirror/language @codemirror/view @codemirror/autocomplete @codemirror/commands @codemirror/language @codemirror/lint @codemirror/state

➡️ #4559 reappears.

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

Have you found out which dependency is breaking?

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

OK I'll check

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

Packages which can be safely updated:

  • @codemirror/language
  • @codemirror/view
  • @codemirror/autocomplete
  • @codemirror/commands
  • @codemirror/language
  • @codemirror/lint
  • @codemirror/state

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

It breaks on the @codemirror/view update.

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

The bug appears as early as with @codemirror/view@6.29.0

@barmac
Copy link
Collaborator Author

barmac commented Sep 26, 2024

OK it actually broke one patch after the current version, so @codemirror/view@6.28.2

This was referenced Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants