Rework and sanity-check harvesting of tin #3197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Bring back deconstruction of pewter items, reimplement salvaging tin from cans via electroplating using new larger can sizes"
Purpose of change
Back in the old days, you could simply scrap tin and pewter items to get tin directly, which back when I added bronze made it a bit more convenient.
Eventually, someone had the clever idea to allow extracting tin from tin cans using electrolysis. This is reasonable, while they aren't made wholly of tin it's still common to plate them, and the intended use case was just to get enough tin to make copper pots. Cans are super common so having to stockpile to make up for a low yield seems reasonable enough to me.
Then it went off the rails when someone else changed the recipe to only use pewter and tin items. This of course defeated literally the entire point of the electroplating PR, that being restricted to looting pewter items was a problem.
The followup to this made tin and pewter items more common, but in exchange it obsoleted the ability to easily deconstruct those items on the basis that it "defeats the purpose of the electrolysis tin crafting recipe," when the purpose had already been defeated by the preceding PR by the same contributor.
This aims to fix the problems caused by all this, along with taking advantage of the fact that nowadays we have larger sizes of cans.
Describe the solution
charges
updated accordingly. The numbers are fudged a lil bit (rough lookup says tin cans have 1-2% tin in them, this is more like 5% to ~5.7% yield) to get the original yield of 10 charges of tin. On the plus side, the 1:5:10 ratio looks less messy than the ratio listed below in alternatives, and unlike the original version of the recipe precludes getting a 250 gram steel chunk out of a 40-gram small can. Still lower yield than the 25% or so the original recipe would get since it was obtaining 10 tin from a single small can.Describe alternatives you've considered
Testing
Checked affected files for syntax and lint errors.
Additional context
Related PR links:
I also plan to do a bit of tweaking to aluminum soon-ish, but when I do, should I go for replacing aluminum ingots with the standard small metal item, or should I just making the ingots a more manageable size (100 ml for example is about right for the archetypal hobbyist muffin tin ingot)?
Worth noting in the above that reducing ingots to 100 ml would make them 270 ml based off their density, and in doing so put things just about right such that we could justify making one with ~20 aluminum cans (13 grams a pop, would be slightly less wonky if adjusted to 14 or 15 grams). That would be a quantity closer to actually worth adding a recipe for aluminum ingots.
On the other hand, converting aluminum to a small metal would mean we could just have it weigh 27 mg per single unit of aluminum, and allow directly scraping aluminum cans into 4-5 units of aluminum without any faffing about with melting it down. Main counterpoints to that are that making muffin pan ingots is a classic metalworking project, and more importantly aluminum powder and aluminum foil make the whole "super low weight stacking aluminum item" category fairly crowded as it is.