Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window resize??? And other minor issues. #162

Closed
bmcassagne opened this issue Jan 7, 2021 · 3 comments
Closed

Window resize??? And other minor issues. #162

bmcassagne opened this issue Jan 7, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@bmcassagne
Copy link

First of all, great program. Greatly appreciated. And I love the new queue system.

  1. Would be great to be able to resize the app because I can't see the full name of many of my videos.
  2. Pausing the queue seems to cause issues. Videos say they've completed but haven't. Other videos get ignored completely. Can't resume the queue.
  3. Videos don't always process in the order of the queue.
  4. Possibly unrelated to the app, but I have 3 computers processing videos. All were approximately the same speed at medium setting, but at slow setting I have one computer processing almost 3 times the speed of the other 2. The slower ones appear more appropriate. About a third of the speed of the medium setting. The one computer is processing almost as fast as it was on medium.
  5. Would be nice to have more options in the presets. Especially to preselect more than one language. The main reason I process my videos is to have my movies with Spanish and english audio. Handbrake worked really well for this allowing me to select the first track of any number of languages.
  6. Options for processing the video streams would be great in the presets also.

And a simple question, does AAC conversion take place at constant bitrate? If so is there any way to implement variable bitrate?

Once again, the app is greatly appreciated!!
@cdgriffith
Copy link
Owner

  1. Thanks for pointing that out, I meant to set it back to "minimum" size after doing my testing and looks like it is set fixed currently.

2-3. If you can remember the behavior that lead to that / GUI logs please let me know. I did just come across an issue that the queue was modifiable when converting, and that should not be happening. In the upcoming beta #161 that will be properly disabled again (can add stuff to it, but not remove stuff from it after it's started). Do you happen to know if any of those times you started an encode and then modified the queue in some way while it was still converting?

  1. Things I would check for: Were the videos all the same type (film / animation) and resolution? Are the versions of FFmpeg the same? (x265 changed how it did presets between some recent versions)

  2. Could you do me a favor and write out the behavior you want for that in a separate ticket? That is definitely a nice to have, and Handbrake is really advanced at that so I don't think I will get to that level anytime soon. But may be able to have some sort of minimal solution.

  3. Do you mean like, always select X video track, or one with largest resolution or something?

  4. Also a good thing for a separate ticket, as you are correct right now it just does constant bitrate for everything. I want to do an audio overhaul at somepoint, but lots of things to do and just one me 😄

Glad you like it and thank you so much for the feedback! It's really helpful getting real use cases and suggestions!

cdgriffith added a commit that referenced this issue Jan 7, 2021
@cdgriffith
* Fixing #162 Main window was not resizeable (thanks to bmcassagne)
9d03286
@cdgriffith cdgriffith mentioned this issue Jan 7, 2021
Merged
cdgriffith added a commit that referenced this issue Jan 8, 2021
@cdgriffith
Beta Version 4.1.0b1 (#161)
a754eb8 
* Adding dual pass option for ffmpeg options (thanks to Catatau)
* Fixing #120 custom bitrate forgets to add a "k" (thanks to seighail3)
* Fixing #162 Main window was not resizeable (thanks to bmcassagne)
@bmcassagne
Copy link
Author

bmcassagne commented Jan 8, 2021 •
edited
Loading

  1. Thanks for the fix!

2-3. I noticed I had to drop a new video on the queue to be able to modify it. I thought that was really strange. Yes, it does lots of weird things after modifying the queue. Also sometimes it will show nothing processing in the queue but the encode status shows something processing.

  1. Seems to be processing at the same speed now. I thought maybe one processor had some optimizations that were particularly useful for slow or something like that. LOL

  2. I'll do that

  3. Sorry I meant to say audio. It would be nice to be able to have the audio codec and bitrate in the presets.

  4. AAC 768kbps seems to be a good compromise for now. I only use it for DTS-HD tracks that aren't DTS-X

OH, and I just noticed something else. It would be AWESOME if the app could recover the queue after a crash/reboot!!! Handbrake does this also.

@cdgriffith cdgriffith added the bug Something isn't working label Jan 9, 2021
@cdgriffith cdgriffith mentioned this issue Jan 9, 2021
Closed
@cdgriffith cdgriffith mentioned this issue Jan 11, 2021
Merged
cdgriffith added a commit that referenced this issue Jan 13, 2021
@cdgriffith @benedicteb
Version 4.1.0 (#169)
e3533a3 
* Adding #118 #126 advanced panel with FFmpeg filters (thanks to Marco Ravich and remlap)
* Adding #114 info panel that shows source details (thanks to leonardyan)
* Adding #117 support for text based burn in subtitles
* Adding #152 option to switch back to old bubbly buttons (thanks to GitKike98)
* Adding logging level selector in settings for GUI
* Adding button to extract text based subtitles
* Adding dual pass option for ffmpeg options (thanks to Catatau)
* Adding #163 elapsed time in encoding panel (thanks to Benedicte Emilie Brækken)
* Adding super secret DEVMODE environment variable
* Adding #168 Allow decimal CRF values as Custom values (thanks to Etz)
* Changing all builds to use Python 3.8, removing idea of "legacy" windows until later time
* Fixing #156 Copy was broken due to ffmpeg extras not being passed (thanks to leonardyan)
* Fixing #158 Translation and icon of tab name "Quality" lost when output codec switched (thanks to leonardyan)
* Fixing #120 Custom bitrate forgets to add a "k" (thanks to seighail3)
* Fixing #162 Main window was not resizeable (thanks to bmcassagne)
* Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz)
* Fixing #154 Overloading the term "Profile" for languages (thanks to leonardyan)
* Fixing snap packaged, and other symlinked FFmpeg installs were not linked correctly (thanks to Catatau)
* Fixing loading video could encounter a bug and crash fastflix (thanks to Jan)
* Fixing being able to set landscape cover
* Fixing resetting covers from queue

Co-authored-by: Benedicte Emilie Brækken <b@brkn.io>
@cdgriffith
Copy link
Owner

Fixing at least the windows resize, maybe some queue issues https://github.com/cdgriffith/FastFlix/releases/tag/4.1.0

Adding tickets for other long term issues #166 #164

If I missed anything please ping again, easy for me to overlook things!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @bmcassagne