Add time elapsed to enoding status tab #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdgriffith
approved these changes
Jan 8, 2021
cdgriffith
reviewed
Jan 8, 2021
Thanks for all the super helpful feedback so far! |
cdgriffith
added a commit
that referenced
this pull request
Jan 9, 2021
…lie Brækken) * Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz)
Merged
cdgriffith
added a commit
that referenced
this pull request
Jan 10, 2021
* Adding #163 elapsed time in encoding panel (thanks to Benedicte Emilie Brækken) * Adding super secret DEVMODE environment variable * Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz) * Fixing #154 Overloading the term "Profile" for languages (thanks to leonardyan) Co-authored-by: Benedicte Emilie Brækken <b@brkn.io>
Merged
cdgriffith
added a commit
that referenced
this pull request
Jan 13, 2021
* Adding #118 #126 advanced panel with FFmpeg filters (thanks to Marco Ravich and remlap) * Adding #114 info panel that shows source details (thanks to leonardyan) * Adding #117 support for text based burn in subtitles * Adding #152 option to switch back to old bubbly buttons (thanks to GitKike98) * Adding logging level selector in settings for GUI * Adding button to extract text based subtitles * Adding dual pass option for ffmpeg options (thanks to Catatau) * Adding #163 elapsed time in encoding panel (thanks to Benedicte Emilie Brækken) * Adding super secret DEVMODE environment variable * Adding #168 Allow decimal CRF values as Custom values (thanks to Etz) * Changing all builds to use Python 3.8, removing idea of "legacy" windows until later time * Fixing #156 Copy was broken due to ffmpeg extras not being passed (thanks to leonardyan) * Fixing #158 Translation and icon of tab name "Quality" lost when output codec switched (thanks to leonardyan) * Fixing #120 Custom bitrate forgets to add a "k" (thanks to seighail3) * Fixing #162 Main window was not resizeable (thanks to bmcassagne) * Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz) * Fixing #154 Overloading the term "Profile" for languages (thanks to leonardyan) * Fixing snap packaged, and other symlinked FFmpeg installs were not linked correctly (thanks to Catatau) * Fixing loading video could encounter a bug and crash fastflix (thanks to Jan) * Fixing being able to set landscape cover * Fixing resetting covers from queue Co-authored-by: Benedicte Emilie Brækken <b@brkn.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks for making this software and all the blog posts. It's super great and has been super helpful to me!
I made this time elapsed label to keep track of how long the current encode command has been running.
Let me know if there are changes you'd like to see before merge 🙂
Summary of changes
started_attoBackgroundRunnerstatus_queue.put(("running",to afterrunner.start_execbecause start time of command is recorded instart_exectimedelta_to_strmethod for having a common serialization (it's quite hacky with only a string split to remove microseconds):to__because ISO formatted timestamps have:in them which made it a little difficult to send it along with the other dataon_status_updatemethod to status panel for listening to status updates frommain