Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Bitrate not shown in UI, when loaded from profile #165

Closed
E-t-z opened this issue Jan 9, 2021 · 2 comments
Closed

Custom Bitrate not shown in UI, when loaded from profile #165

E-t-z opened this issue Jan 9, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@E-t-z
Copy link

E-t-z commented Jan 9, 2021 •
edited
Loading

When you create custom profile, for example Bitrate 16000k,
it will revert to lowest available (500k) in UI if you reload that profile later.

In YAML, it seems to have stored correct value though.

    x264:
      bitrate: 16000k
      crf: null
      extra: ''
      max_muxing_queue_size: '1024'
      pix_fmt: yuv420p
      preset: slower
      profile: default
      tune: null
    x265: null

In my opinion, UI should show actual configured values, in this case Custom and 16000k

Now when you load that profile, and Add that job to queue, it will apply lowest possible value 500k and will encode with it.
@E-t-z E-t-z changed the title Custom Bitrate not saved into profile Custom Bitrate not shown in UI, when loaded from profile Jan 9, 2021
@cdgriffith cdgriffith added the bug Something isn't working label Jan 9, 2021
@E-t-z
Copy link
Author

E-t-z commented Jan 9, 2021

It does look like, it simply does not load that value from YAML, which causes those issues.

cdgriffith added a commit that referenced this issue Jan 9, 2021
@cdgriffith
* Adding #163 elapsed time in encoding panel (thanks to Benedicte Emi…
1f8be8a 
…lie Brækken)

* Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz)
@cdgriffith cdgriffith mentioned this issue Jan 10, 2021
Merged
cdgriffith added a commit that referenced this issue Jan 10, 2021
@cdgriffith @benedicteb
Beta Version 4.1.0b2 (#167)
2228fed 
* Adding #163 elapsed time in encoding panel (thanks to Benedicte Emilie Brækken)
* Adding super secret DEVMODE environment variable
* Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz)
* Fixing #154 Overloading the term "Profile" for languages (thanks to leonardyan)

Co-authored-by: Benedicte Emilie Brækken <b@brkn.io>
@cdgriffith cdgriffith mentioned this issue Jan 11, 2021
Merged
cdgriffith added a commit that referenced this issue Jan 13, 2021
@cdgriffith @benedicteb
Version 4.1.0 (#169)
e3533a3 
* Adding #118 #126 advanced panel with FFmpeg filters (thanks to Marco Ravich and remlap)
* Adding #114 info panel that shows source details (thanks to leonardyan)
* Adding #117 support for text based burn in subtitles
* Adding #152 option to switch back to old bubbly buttons (thanks to GitKike98)
* Adding logging level selector in settings for GUI
* Adding button to extract text based subtitles
* Adding dual pass option for ffmpeg options (thanks to Catatau)
* Adding #163 elapsed time in encoding panel (thanks to Benedicte Emilie Brækken)
* Adding super secret DEVMODE environment variable
* Adding #168 Allow decimal CRF values as Custom values (thanks to Etz)
* Changing all builds to use Python 3.8, removing idea of "legacy" windows until later time
* Fixing #156 Copy was broken due to ffmpeg extras not being passed (thanks to leonardyan)
* Fixing #158 Translation and icon of tab name "Quality" lost when output codec switched (thanks to leonardyan)
* Fixing #120 Custom bitrate forgets to add a "k" (thanks to seighail3)
* Fixing #162 Main window was not resizeable (thanks to bmcassagne)
* Fixing #165 Custom Bitrate loaded from Profile (thanks to Etz)
* Fixing #154 Overloading the term "Profile" for languages (thanks to leonardyan)
* Fixing snap packaged, and other symlinked FFmpeg installs were not linked correctly (thanks to Catatau)
* Fixing loading video could encounter a bug and crash fastflix (thanks to Jan)
* Fixing being able to set landscape cover
* Fixing resetting covers from queue

Co-authored-by: Benedicte Emilie Brækken <b@brkn.io>
@cdgriffith
Copy link
Owner

Thanks for the report! Should be fixed in https://github.com/cdgriffith/FastFlix/releases/tag/4.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @E-t-z