Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audio disabled when editing queue item #398

Closed
philblue1 opened this issue Dec 21, 2022 · 4 comments
Closed

audio disabled when editing queue item #398

philblue1 opened this issue Dec 21, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@philblue1
Copy link

philblue1 commented Dec 21, 2022 •
edited
Loading

When using the edit button of an queue item the audio track is disabled.

FastFlix 5.1.0
Windows
@dongafford
Copy link

I have noticed this issue as well. When you edit the item in the queue, it will disable audio and subtitles. You will need to re-enable them on those tabs.

@cdgriffith cdgriffith added the bug Something isn't working label Jan 29, 2023
cdgriffith added a commit that referenced this issue Jan 31, 2023
@cdgriffith
* Fixing #398 audio and subtitles disabled when editing queue item (t…
d26cc09 
…hanks to philblue1 and Don Gafford)
@cdgriffith cdgriffith mentioned this issue Feb 4, 2023
Merged
@dongafford
Copy link

Hi, Chris.

Thanks for fixing this and sorry to bring this old item back to life. I noticed this bug also affected the cover image selection (Copy Cover) on the Cover tab. I'm not sure how close you are to 5.2.0, but I wanted to make sure that your fix covered this as well. If not, I'm sure we'll see it in a later version.

Thanks again.

@cdgriffith cdgriffith mentioned this issue Feb 16, 2023
Closed
@cdgriffith
Copy link
Owner

Thanks for bringing it up! Didn't notice that, adding separate ticket to make sure I don't lose it.

cdgriffith added a commit that referenced this issue Mar 9, 2023
@cdgriffith
Version 5.2.0 (#407)
1967921 
* Adding #100 Output format selection (thanks to me)
* Adding #227 load directory of videos support (thanks to Chris / moonwhaler and a lot of others)
* Adding #233 Versatile Video Coding (aka x266) support (thanks to F.O.R.A.R.T.)
* Adding #200 #320 #373 UI scaling (thanks to tyeeman, wynterca and reza)
* Adding #367 safer font defaults (thanks to Archer Allstars)
* Adding #242 and #400 resolution saves to the profile (thanks to x9sim9)
* Adding #409 Copy video track title information from input file (thanks to Don Gafford)
* Adding #422 Add ICQ and LA-ICQ for rigayas QSV (thanks to @Bender1984)
* Adding pip builds again allow for `pipx` install
* Adding Ukrainian ( Українська ) language support
* Adding Korean ( 한국어 ) language support
* Adding default log cleanup on exit, can be disabled in settings
* Fixing #332 Command Window always shows "qt.svg: Cannot open file" errors (thanks to Wontell)
* Fixing #350 Unable to burn in subtitles (thanks to Maddie Davis)
* Fixing #398 audio and subtitles disabled when editing queue item (thanks to philblue1 and Don Gafford)
* Fixing #413 Wrong equalizer settings with not US locales (thanks to Massimo Pissarello)
* Fixing #421 Queue extras were not ever being cleaned up (thanks to Maddie Davis)
* Fixing QSV AV1 setting panel issues
* Fixing app could crash on startup if could not check for updates to github due to rate limiting
* Fixing removing legacy pkg_resources for importlib.resources
@cdgriffith
Copy link
Owner

Fixed in 5.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdgriffith @dongafford @philblue1