Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy video track title information from input file #409

Closed
dongafford opened this issue Feb 16, 2023 · 14 comments
Closed

Copy video track title information from input file #409

dongafford opened this issue Feb 16, 2023 · 14 comments
Labels
bug Something isn't working

Comments

@dongafford
Copy link

dongafford commented Feb 16, 2023

Hi. Currently FastFlix doesn't copy the title information ('Name' field for the video track in MKVToolnix) when encoding files. I would like to see if this data could be copied if it exists. I have to manually remux files to get this information back into the encoded file once FastFlix has completed the encode.

Currently FastFlix will copy this information for the Audio and Subtitle tracks.

Thanks

@cdgriffith cdgriffith added the bug Something isn't working label Feb 16, 2023
@cdgriffith
Copy link
Owner

cdgriffith commented Feb 16, 2023

Yeah I got rid of that field in 5.2.0 beta to save space up there then...forgot to add it back anywhere. (Though I thought it would just copy as is, guess my logic was off for that too!) Thanks for the ticket!

@dongafford
Copy link
Author

Hi, Chris. I haven't tried this in the 5.2.0 beta. I'm still running 5.1.0. Not sure if you tried it yourself and it's still broken.

@cdgriffith
Copy link
Owner

Ohh, make sure you don't have "remove metadata" selected on the right hand side, and I think it should copy then

@dongafford
Copy link
Author

dongafford commented Feb 16, 2023

EDIT: Ugh. I just saw your mention of the Remove Metadata option. I see it's checked by default. Checking things now.

Hi, Chris.

I tested this issue with the 5.2.0 beta. You are correct, I no longer see the 'title' field in the top area of the window. That has been useful for me in the past (edit a typo), but usually I've configured that field correctly before I get to the FastFlix step.

I tested the encode with an "extras" file (documentary included with a disc), and I'm seeing the same behavior. The "name" goes away for the video track. I've included screenshots from MKVToolnix GUI.

Please let me know if you want me to test anything.

Original File
Original File

After Encode
After Encode

@dongafford
Copy link
Author

Running the 5.2.0b1 Beta.

I ran the encode twice with remove metadata unchecked and still saw the same behavior. The name value for the video track is cleared. The name value in the audio track is the same as the source file

I was trying to figure out how to make the remove metadata option the default, but it's not bubbled up in the GUI. I closed the GUI down and edited the YAML file to set remove_metadata to false. I saved it and went into FastFlix and the Remove Metadata box is selected by default.

I loaded a new source and it stayed selected. I chose a different profile, then back to my profile in the YAML file and it kept the setting checked. If I uncheck it and Add to Queue, the checkbox checks itself (but greyed as I don't have a source file loaded). When I load a new source file with my profile active, the option stays checked until I uncheck it.

@cdgriffith
Copy link
Owner

cdgriffith commented Feb 25, 2023

Could you check if you load that video into FastFlix and look at the Source Details page, if you could copy in the output could help make sure I start copying the right thing.

The example I have looks like it might be storing title under HANDLER_NAME in the tags, want to make sure that is the case.

tags:
  language: eng
  HANDLER_NAME: VideoHandle

cdgriffith added a commit that referenced this issue Feb 25, 2023
@cdgriffith
Copy link
Owner

Not most elegant solution, and no way to put them in profile yet, but do have a way to at least change them and should auto passthrough on the Advanced page now (didn't have video to test regular title with tonight, but video track handler name goes through) https://github.com/cdgriffith/FastFlix/releases/tag/5.2.0b2

@dongafford
Copy link
Author

dongafford commented Feb 27, 2023

Hi, Chris.

Sorry for the late response. It was patching weekend and things went sideways :-)

I don't have the file I was referencing before, but I have another one I was working on. The source details are attached. I found the title under the tags: section. Here's a snippet of the output:

tags:
language: eng
title: Merrily We Go to Hell - Film Historian Cari Beauchamp Interview
BPS-eng: '31064561'
DURATION-eng: 00:26:33.592000000
NUMBER_OF_FRAMES-eng: '38208'
NUMBER_OF_BYTES-eng: '6188029598'

Source Details.txt

As soon as my queues are completed, I'll switch over to 5.2.0b2 and check that version.

Thanks again.

@dongafford
Copy link
Author

I just finished encoding the file referenced above with 5.2.0b1. It copied the title information into the new file.

@dongafford
Copy link
Author

dongafford commented Feb 27, 2023

OK. I found one that didn't work with 5.2.0b1. Source details and Raw Commands are attached below. I encoded 4 other files from this directory / movie. The title information from those copied over.

There are a lot of commonalities between what does and doesn't work. I had another file that transferred with two dashes, so I'm unsure what's going on here.

tags:
language: eng
title: Luca - Summer -- English Teaser Trailer
BPS-eng: '20764806'

Source Details.txt
Raw Commands.txt

I'll try this with 5.2.0b2 soon.

@dongafford
Copy link
Author

Here's another one. Two files, same directory.
This one's title didn't transfer:
Mad Max 2- The Road Warrior - Leonard Maltin Introduction Source Details.txt

This one did:
Mad Max 2- The Road Warrior - Theatrical Trailer Source Details.txt

I thought it might be special characters, but these both have colons in the title.

@dongafford
Copy link
Author

OK. This did not work with 5.0.2b2, but did work with 5.2.0b3.

I tested this with both files that had an issue with 5.2.0b1 and both had the title information in the output file.

@cdgriffith
Copy link
Owner

As an update I did a bit of a tweak with latest beta 4 to specifically only copy title and not video handler any more, so if that breaks any of your flows please let me know!

cdgriffith added a commit that referenced this issue Mar 9, 2023
* Adding #100 Output format selection (thanks to me)
* Adding #227 load directory of videos support (thanks to Chris / moonwhaler and a lot of others)
* Adding #233 Versatile Video Coding (aka x266) support (thanks to F.O.R.A.R.T.)
* Adding #200 #320 #373 UI scaling (thanks to tyeeman, wynterca and reza)
* Adding #367 safer font defaults (thanks to Archer Allstars)
* Adding #242 and #400 resolution saves to the profile (thanks to x9sim9)
* Adding #409 Copy video track title information from input file (thanks to Don Gafford)
* Adding #422 Add ICQ and LA-ICQ for rigayas QSV (thanks to @Bender1984)
* Adding pip builds again allow for `pipx` install
* Adding Ukrainian ( Українська ) language support
* Adding Korean ( 한국어 ) language support
* Adding default log cleanup on exit, can be disabled in settings
* Fixing #332 Command Window always shows "qt.svg: Cannot open file" errors (thanks to Wontell)
* Fixing #350 Unable to burn in subtitles (thanks to Maddie Davis)
* Fixing #398 audio and subtitles disabled when editing queue item (thanks to philblue1 and Don Gafford)
* Fixing #413 Wrong equalizer settings with not US locales (thanks to Massimo Pissarello)
* Fixing #421 Queue extras were not ever being cleaned up (thanks to Maddie Davis)
* Fixing QSV AV1 setting panel issues
* Fixing app could crash on startup if could not check for updates to github due to rate limiting
* Fixing removing legacy pkg_resources for importlib.resources
@cdgriffith
Copy link
Owner

Added in 5.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants