Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR10+ Extract Broken? #421

Closed
mrdav1 opened this issue Mar 4, 2023 · 4 comments
Closed

HDR10+ Extract Broken? #421

mrdav1 opened this issue Mar 4, 2023 · 4 comments

Comments

@mrdav1
Copy link

mrdav1 commented Mar 4, 2023

I am running FastFlix 5.1.0 on Windows 10 and when I try to extract HDR10+ metadata the following error occurs:

2023-03-04 12:17:31 Study fastflix[13212] INFO Generating thumbnail: "C:\Users\Maddie\AppData\Roaming\FFmpeg\bin\ffmpeg.exe" -ss 159.28 -loglevel warning -i "D:\Users\Maddie\Videos\To Master\TV\05 Servant (2160p WEB CAKES)\08 Tunnels (2160p HD).mkv" -init_hw_device opencl=ocl -filter_hw_device ocl -filter_complex "[0:0]format=p010,hwupload,tonemap_opencl=tonemap=hable:desat=0:r=tv:p=bt709:t=bt709:m=bt709:format=nv12,hwdownload,format=nv12,scale='min(440,iw):-8'[v]" -map "[v]" -an -y -map_metadata -1 -frames:v 1 "D:\Users\Maddie\AppData\Roaming\FastFlix\thumbnail_preview.jpg"
2023-03-04 12:18:07 Study fastflix[13212] INFO Extracting HDR10+ metadata to D:\Users\Maddie\AppData\Roaming\FastFlix\temp_f256862e71906b33be11d721\metadata.json
2023-03-04 12:18:07 Study fastflix[13212] WARNING Using HDR10 parser version 1.6.0
2023-03-04 12:18:07 Study fastflix[13212] WARNING Running command: C:\Users\Maddie\AppData\Roaming\FFmpeg\bin\ffmpeg.exe -y -i D:\Users\Maddie\Videos\To Master\TV\05 Servant (2160p WEB CAKES)\08 Tunnels (2160p HD).mkv -map 0:0 -c:v copy -vbsf hevc_mp4toannexb -f hevc - | C:\Users\Maddie\AppData\Roaming\FFmpeg\bin\hdr10plus_tool.exe extract -o D:\Users\Maddie\AppData\Roaming\FastFlix\temp_f256862e71906b33be11d721\metadata.json -
Traceback (most recent call last):
File "fastflix\widgets\background_tasks.py", line 165, in run
if line := f.readline().rstrip():
File "codecs.py", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 0-1: unexpected end of data

This has worked OK in the past.

Please help.

@mrdav1
Copy link
Author

mrdav1 commented Mar 4, 2023

Update: I managed to get it to work by doing some housekeeping. I deleted hundreds of empty folders in "D:\Users\Maddie\AppData\Roaming\FastFlix" (I guess they're left for previous encodes?) and now it all works OK.

@cdgriffith
Copy link
Owner

Thanks for the update, I will see what I can do for better cleanup!

@mrdav1
Copy link
Author

mrdav1 commented Mar 6, 2023

That would be greatly appreciated. I've just found that "...\AppData\Roaming\FastFlix\queue_extras" contains over 15,000 files equalling 2TB of old metadata!

cdgriffith added a commit that referenced this issue Mar 7, 2023
…Maddie Davis)

* Fixing app could crash on startup if could not check for updates to github due to rate limiting
* Adding UI scale
* Adding default log cleanup on exit, can be disabled in settings
cdgriffith added a commit that referenced this issue Mar 9, 2023
* Adding #100 Output format selection (thanks to me)
* Adding #227 load directory of videos support (thanks to Chris / moonwhaler and a lot of others)
* Adding #233 Versatile Video Coding (aka x266) support (thanks to F.O.R.A.R.T.)
* Adding #200 #320 #373 UI scaling (thanks to tyeeman, wynterca and reza)
* Adding #367 safer font defaults (thanks to Archer Allstars)
* Adding #242 and #400 resolution saves to the profile (thanks to x9sim9)
* Adding #409 Copy video track title information from input file (thanks to Don Gafford)
* Adding #422 Add ICQ and LA-ICQ for rigayas QSV (thanks to @Bender1984)
* Adding pip builds again allow for `pipx` install
* Adding Ukrainian ( Українська ) language support
* Adding Korean ( 한국어 ) language support
* Adding default log cleanup on exit, can be disabled in settings
* Fixing #332 Command Window always shows "qt.svg: Cannot open file" errors (thanks to Wontell)
* Fixing #350 Unable to burn in subtitles (thanks to Maddie Davis)
* Fixing #398 audio and subtitles disabled when editing queue item (thanks to philblue1 and Don Gafford)
* Fixing #413 Wrong equalizer settings with not US locales (thanks to Massimo Pissarello)
* Fixing #421 Queue extras were not ever being cleaned up (thanks to Maddie Davis)
* Fixing QSV AV1 setting panel issues
* Fixing app could crash on startup if could not check for updates to github due to rate limiting
* Fixing removing legacy pkg_resources for importlib.resources
@cdgriffith
Copy link
Owner

Automatic cleanup now in 5.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants