fix!: use correct chain-id when filtering and checking txs

[evan-forbes]

Overview

consistently pass the correct chain-id to the application using RequestPrepareProposal and RequestProcessProposal

this PR still needs to update the go.mod to use the official tag of tendermint after its released

closes #2020 and #2021

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

[adlerjohn]

unit tests failing?

[evan-forbes]

unit tests failing?

yeah sorry, waiting for tests to finish locally but they should be fixed

edit: gahhh one sec these tests need to be updated... we can review celestiaorg/celestia-core#1028 tho

[rach-id]

[rootulp]

[not blocking] I think there's a subtle bug here b/c this comparison doesn't account for the namespace version. I can fix in a follow up PR or this can use something like:

celestia-app/pkg/square/builder.go

Lines 136 to 140 in 3f71f97

	// sort the blobs in order of namespace. We use slice stable here to respect the
	// order of multiple blobs within a namespace as per the priority of the PFB
	sort.SliceStable(b.blobs, func(i, j int) bool {
	return bytes.Compare(fullNamespace(b.blobs[i].blob), fullNamespace(b.blobs[j].blob)) < 0
	})

Suggested change

	func SortBlobs(blobs []types.Blob) []types.Blob {
	sort.Slice(blobs, func(i, j int) bool { return bytes.Compare(blobs[i].NamespaceID, blobs[j].NamespaceID) < 0 })
	return blobs
	}
	func SortBlobs(blobs []types.Blob) []types.Blob {
	sort.SliceStable(blobs, func(i, j int) bool {
	return bytes.Compare(fullNamespace(blobs[i]), fullNamespace(blobs[j])) < 0
	})
	return blobs
	}
	// TODO: celestia-core should provide this method for `Blob`s
	func fullNamespace(blob types.Blob) []byte {
	return append([]byte{byte(blob.NamespaceVersion)}, blob.NamespaceID...)
	}

not blocking b/c in practice I can't think of a scenario where not accounting for the namespace version would result in a different ordering b/c there are only two versions (0 and 255) and the reserved namespaces that use 255 have IDs that would be ordered after every blob namespace ID

[evan-forbes]

good find, and yeah this is using the same as what we were using before (only for tests as well I believe)

[rootulp]

👍

[codecov-commenter]

Codecov Report

Merging #2022 (9091c3c) into main (30c50a0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   21.54%   21.54%           
=======================================
  Files         127      127           
  Lines       14293    14293           
=======================================
  Hits         3079     3079           
  Misses      10922    10922           
  Partials      292      292           

Impacted Files	Coverage Δ
app/prepare_proposal.go	0.00% <0.00%> (ø)
app/process_proposal.go	0.00% <0.00%> (ø)