feat: pass chain-id in prepareProposal #1028
Conversation
| repeated bytes data = 1; | ||
| repeated NMTProof share_proofs = 2; | ||
| bytes namespace_id = 3; | ||
| RowProof row_proof = 4; | ||
| uint32 namespace_version = 5; | ||
| repeated bytes data = 1; | ||
| repeated NMTProof share_proofs = 2; | ||
| bytes namespace_id = 3; | ||
| RowProof row_proof = 4; | ||
| uint32 namespace_version = 5; |
There was a problem hiding this comment.
called proto lint + format, not sure why our protobuf linter doesn't also call those
|
my protobuf setup adds an extra line either we can fix later, or someone with an identical setup to the CI can push to fix, but I don't think we should block on that given we need to ship asap |
There was a problem hiding this comment.
either we can fix later, or someone with an identical setup to the CI can push to fix
- Can you open an issue to look into this
- Can you just manually edit the files to match? Otherwise all subsequent PRs will also have this check broken and actual bugs might slip through!
@sweexordious has a setup identical to CI, so this has fixed it. In the meantime I'll try and fix my local setup, or update the CI |
| @@ -133,6 +133,8 @@ message RequestPrepareProposal { | |||
| tendermint.types.Data block_data = 1; | |||
| // If an application decides to populate block_data with extra information, they can not exceed this value. | |||
| int64 block_data_size = 2; | |||
| // proposal_header is the header from the proposal | |||
There was a problem hiding this comment.
[question] is this godoc copied from somewhere? If not, proposal to make the godoc reference the field name b/c I'm not sure what the relationship is between proposal_header and chain_id but they seem distinct.
| // proposal_header is the header from the proposal | |
| // chain_id is a unique identifier for the blockchain network this proposal belongs to (e.g. mocha-1) |
There was a problem hiding this comment.
I'll create an issue for this one, as changing will require recompiling the proto and the CI and my setup and different somehow despite using the same versions...
* feat: pass chain-id in prepareProposal * chore: proto-gen --------- Co-authored-by: rachid <chamirachid1@gmail.com>
* feat: pass chain-id in prepareProposal * chore: proto-gen --------- Co-authored-by: rachid <chamirachid1@gmail.com>
The cosmos-sdk doesn't have a good way to access the chain-id from the app atm, so we're passing via prepareProposal instead
closes #1027
part of fixing celestiaorg/celestia-app#2020