-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Allows writing lint-friendly tests" #306
Conversation
👍 |
😦 |
Revert "Allows writing lint-friendly tests"
Perhaps a |
Just wonder if you guys are going to revert this or just leave it until people start to use the new syntax in their code... The chaijs website was also updated to document this new syntax. If we wait too long, reverting may end up being a backcompat issue. |
@joshperry indeed. |
I think this change should be published asap (and marked as breaking) as it is advertised for ~ 2 months on your homepage and we (and I think others) already converted our projects to the new syntax. |
Yes, you're very right @johanneswuerbach. I'm going to work on getting a release out as soon as I can. |
modify unit tests due to breaking changes from chai 1.10 -> 2.0 chaijs/chai#308 chaijs/chai#306
@paul-barry-kenzan I was wondering the same thing. There seems to be some more context here: #371 (comment) |
Reverts #297
@logicalparadox @joshperry