Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allows writing lint-friendly tests" #306

Merged
merged 1 commit into from
Nov 13, 2014

Conversation

keithamus
Copy link
Member

@logicalparadox
Copy link
Member

👍

@keithamus
Copy link
Member Author

😦

keithamus added a commit that referenced this pull request Nov 13, 2014
Revert "Allows writing lint-friendly tests"
@keithamus keithamus merged commit b71b930 into master Nov 13, 2014
@keithamus keithamus deleted the revert-297-noopchainfunc branch November 13, 2014 14:39
@keithamus
Copy link
Member Author

Perhaps a 1.10.1/1.11.0 release?

@joshperry
Copy link
Contributor

Just wonder if you guys are going to revert this or just leave it until people start to use the new syntax in their code... The chaijs website was also updated to document this new syntax. If we wait too long, reverting may end up being a backcompat issue.

@keithamus
Copy link
Member Author

@joshperry indeed. master has been reverted we just need to cut a new release - which is dependant on #337

@johanneswuerbach
Copy link

I think this change should be published asap (and marked as breaking) as it is advertised for ~ 2 months on your homepage and we (and I think others) already converted our projects to the new syntax.

@keithamus
Copy link
Member Author

Yes, you're very right @johanneswuerbach. I'm going to work on getting a release out as soon as I can.

@keithamus keithamus mentioned this pull request Feb 12, 2015
koulmomo added a commit to yahoo/fluxible-action-utils that referenced this pull request Feb 26, 2015
modify unit tests due to breaking changes from chai 1.10 -> 2.0
chaijs/chai#308
chaijs/chai#306
@sankethkatta
Copy link

@paul-barry-kenzan I was wondering the same thing. There seems to be some more context here: #371 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants