chaijs 1.10 allows to write lint-friendly tests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`be.ok;` and others can now be written as `be.ok();`
|
Note: this behavior has been reverted in Chai master, and is slated to go out in the next release. Additionally, using this lint-friendly syntax is incompatible with chai-as-promised. |
|
o.O I was definitely not aware that this was rolled back thanks. It is still advertised on their homepage (for 2 months now) and I guess we were not the only ones who converted their projects ... |
|
Same as emberjs/ember-mocha#13 (comment) |
|
I'm using https://github.com/prodatakey/dirty-chai to deal with this. I think the chai project is nuts for pushing a single style that forces people to disable a whole class of safety checks in their test code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be.ok;and others can now be written asbe.ok();Fixes #6
More details chaijs/chai#297