Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming workdir into workingDir #22

Closed
l0rd opened this issue Feb 6, 2020 · 4 comments · Fixed by #35
Closed

Renaming workdir into workingDir #22

l0rd opened this issue Feb 6, 2020 · 4 comments · Fixed by #35
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 6, 2020

Example with proposed changes:

commands:
 - exec:
     commandLine: "./buildSchema.sh"
     workingDir: "~/schemaScripts"
     component: build-tools
     alias: buildSchema
@l0rd l0rd mentioned this issue Feb 6, 2020
28 tasks
@l0rd
Copy link
Contributor Author

l0rd commented Feb 6, 2020

cc @johnmcollier @elsony

@davidfestal
Copy link
Collaborator

There is already a workDir attribute for the exec commands in the current proposal on master.
But it was not mentioned in any samples.
Using it would be like that:

  - exec:
      commandLine: "./buildSchema.sh"
      component: build-tools
      alias: buildSchema
      workdir: /projects/myProject

Of course the name can be changed if necessary.

@l0rd l0rd changed the title Working directory for a specific command Renaming workdir into workingDir Feb 25, 2020
@l0rd
Copy link
Contributor Author

l0rd commented Feb 25, 2020

Description and title changed with a new proposal (renaming workdir) after review.

davidfestal added a commit that referenced this issue Apr 3, 2020
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal added a commit that referenced this issue Apr 22, 2020
* Implement agreement on issue #18
* Implement agreement on issue #17
* Implement agreement on issue #21
* Implement agreement on issue #22
* Implement agreement on issue #27
* Implement agreement on issue #9
* Implement agreement on issue #10
* Fix PR comments about issue #9 PR comment #35 (comment)
* Fix PR comments about issue #17 PR comment #35 (comment)
* Implement agreement on issue #14 and  #19
* Add the spring boot example
* Implement agreement on issue #32
* Fix last PR comments

Signed-off-by: David Festal <dfestal@redhat.com>

Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
@l0rd l0rd added this to the 2.0.0 milestone Jun 16, 2020
@davidfestal davidfestal linked a pull request Jun 22, 2020 that will close this issue
@davidfestal
Copy link
Collaborator

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants