ExtModule's lacked support built in support for providing #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the verilog source. This changes creates traits that can be used with ExtModule to provide the support currently found in BlackBox - Add support for ExtModule helpers - HasExtModuleResource to use addResource - HasExtModuleInline to use setInline - HasExtModulePath to use addPath - Add tests of the above support. - Note: These tests use Stage instead of Driver - Added ScalaDoc for HasBlackBoxInline#setInline
chick
added
release issue
Feature
seldridge
previously requested changes
Aug 19, 2019
|
@seldridge Thanks, I like the idea of trailing commas, but I've got to find some mechanism for warning me when I commit with them. BTW, I haven't seen the suggested change in a code comment before. Is that some new feature? |
seldridge
approved these changes
Oct 13, 2020
| TargetDirAnnotation(targetDir), | ||
| ChiselGeneratorAnnotation(() => new UsesExtModuleAddViaInline) | ||
| ) | ||
| val newAnnotations = (new ChiselStage).run(annotations) |
There was a problem hiding this comment.
It would be better to use the transform or execute methods instead of run. The latter is what the user is supposed to implement, while the former two are running all the pre- and post-run steps.
Ditto for other usages below.
There was a problem hiding this comment.
Changed to use .transform
|
We forgot to backport this which is causing the tests in #1650 to fail on 3.4.x |
|
@Mergifyio backport 3.4.x |
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2020
* ExtModule's lacked support built in support for providing the verilog source. This changes creates traits that can be used with ExtModule to provide the support currently found in BlackBox - Add support for ExtModule helpers - HasExtModuleResource to use addResource - HasExtModuleInline to use setInline - HasExtModulePath to use addPath - Add tests of the above support. - Note: These tests use Stage instead of Driver - Added ScalaDoc for HasBlackBoxInline#setInline * Fix the danged trailing commas. * Change to use `.transform` as the correct API for `ChiselStage` (cherry picked from commit fd92809)
|
Command
|
mergify bot
added a commit
that referenced
this pull request
Nov 2, 2020
) * ExtModule's lacked support built in support for providing the verilog source. This changes creates traits that can be used with ExtModule to provide the support currently found in BlackBox - Add support for ExtModule helpers - HasExtModuleResource to use addResource - HasExtModuleInline to use setInline - HasExtModulePath to use addPath - Add tests of the above support. - Note: These tests use Stage instead of Driver - Added ScalaDoc for HasBlackBoxInline#setInline * Fix the danged trailing commas. * Change to use `.transform` as the correct API for `ChiselStage` (cherry picked from commit fd92809) Co-authored-by: Chick Markley <chick@qrhino.com>
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Fixes #1154 * Tests that #1154 example produces SyntaxErrorsException * Generally helps catch trailing syntax errors * Performance-neutral relative to previous grammar * Recommended by antlr4 devs, can help performance in some cases * See antlr/antlr4#1540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inconsistent API between ExtModule and BlackBox
ExtModule's lacked support built in support for providing the verilog source. This changes creates traits that can be used with ExtModule to provide the support currently found in BlackBox
Type of change: Make ExtModule consistent with BlackBox
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
ExtModule now has support for 3 methods of providing the underlying verilog implementations: in-line string, scala/java resource (best for use in libraries), and via a file path name.