Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtModule's lacked support built in support for providing (bp #1154) #1651

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 2, 2020

This is an automated backport of pull request #1154 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* ExtModule's lacked support built in support for providing
the verilog source. This changes creates traits that
can be used with ExtModule to provide the support currently found in
BlackBox

- Add support for ExtModule helpers
  - HasExtModuleResource to use addResource
  - HasExtModuleInline to use setInline
  - HasExtModulePath to use addPath
- Add tests of the above support.
  - Note: These tests use Stage instead of Driver
- Added ScalaDoc for HasBlackBoxInline#setInline

* Fix the danged trailing commas.

* Change to use `.transform` as the correct API for `ChiselStage`

(cherry picked from commit fd92809)
@mergify mergify bot requested a review from a team as a code owner November 2, 2020 20:53
@mergify mergify bot requested review from ducky64 and removed request for a team November 2, 2020 20:53
@mergify mergify bot added the Backport Automated backport, please consider for minor release label Nov 2, 2020
@mergify mergify bot merged commit 6b22ccb into 3.4.x Nov 2, 2020
@mergify mergify bot deleted the mergify/bp/3.4.x/pr-1154 branch November 2, 2020 21:35
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
…,Upper}CaseNames Transforms (#1651)

* Revert "Add test of {Lower, Upper}CaseNames"

This reverts commit 93c078b.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

* Revert "Add --change-name-case <lower|upper> option"

This reverts commit d3ab7e2.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

* Revert "Add features.{LowerCaseNames, UpperCaseNames} transforms"

This reverts commit c8dcdac.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

* Revert "Refactor RemoveKeywordCollisions->ManipulateNames"

This reverts commit c534c5a.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants