Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to Naming Cookbook #2356

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix link to Naming Cookbook #2356

merged 1 commit into from
Jan 20, 2022

Conversation

jackkoenig
Copy link
Contributor

#naming implies within the current file. Removing the # refers to a file in the current directory.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • [NA] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig
Fix link to Naming Cookbook
fed4307 
#naming implies within the current file. Removing the # refers to a file in the current directory.
@jackkoenig jackkoenig added this to the 3.5.x milestone Jan 20, 2022
@jackkoenig jackkoenig merged commit 512ddd6 into master Jan 20, 2022
@jackkoenig jackkoenig deleted the fix-link-to-naming-cookbook branch January 20, 2022 06:58
mergify bot pushed a commit that referenced this pull request Jan 20, 2022
@jackkoenig
Fix link to Naming Cookbook (#2356)
9dd6f8b 
#naming implies within the current file. Removing the # refers to a file in the current directory.

(cherry picked from commit 512ddd6)
@mergify mergify bot mentioned this pull request Jan 20, 2022
Merged
@mergify mergify bot added the Backported This PR has been backported label Jan 20, 2022
mergify bot added a commit that referenced this pull request Jan 20, 2022
@mergify @jackkoenig
Fix link to Naming Cookbook (#2356) (#2357)
a0798dc 
#naming implies within the current file. Removing the # refers to a file in the current directory.

(cherry picked from commit 512ddd6)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@sequencer sequencer mentioned this pull request May 3, 2022
Open
14 tasks
jackkoenig added a commit that referenced this pull request Feb 28, 2023
@jackkoenig
Bump Scala to 2.12.14 and 2.13.6 (#2356)
8421e96 
This required also bumping sbt-scalafix to bring in a newer version of
semanticdb. The new version of semanticdb had an issue with a regex in
SMTLib, fixed by fixing the way '$' is escaped in the regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge