Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved D/I internals to new core package #2488

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Moved D/I internals to new core package #2488

merged 2 commits into from
Apr 15, 2022

Conversation

azidar
Copy link
Contributor

@azidar azidar commented Apr 15, 2022

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • [N/A] Did you add at least one test demonstrating the PR?
  • [N/A] Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • [N/A] Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code refactoring

API Impact

Moves files around and added a new package, so its possible that existing code may break if it is relying on these. However, most of the non-internal types and objects are aliased in the hierarchy package.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Move D/I internals to a core package, aliased public types and objects to keep mostly backwards compatible.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@azidar azidar requested a review from jackkoenig April 15, 2022 22:05
@jackkoenig jackkoenig added this to the 3.6.0 milestone Apr 15, 2022
@jackkoenig
Copy link
Contributor

This is a binary incompatible change so marked 3.6.0.

@azidar azidar enabled auto-merge (squash) April 15, 2022 22:31
@azidar azidar mentioned this pull request Apr 15, 2022
Merged
8 tasks
@azidar azidar merged commit 661ab36 into master Apr 15, 2022
@azidar azidar deleted the move-di-files branch April 15, 2022 22:45
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@seldridge
[spec] Remove FIRRTL Specification (#2488)
a372c20 
This removes the FIRRTL specification as this now lives in its own
repository:

    https://github.com/chipsalliance/firrtl-spec

All git history (excluding binary updates to spec.pdf) have been
migrated to the new repository.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@azidar @jackkoenig