Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor D/I: Move clone class definitions to hierarchy package #2489

Merged
merged 5 commits into from
Apr 15, 2022

Conversation

azidar
Copy link
Contributor

@azidar azidar commented Apr 15, 2022

Should follow after merging #2488

Contributor Checklist

  • [N/A] Did you add Scaladoc to every public function/method?
  • [N/A] Did you add at least one test demonstrating the PR?
  • [N/A] Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • [N/A] Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • [N/A] Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [N/A] Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Moves some classes into the experimental.hierarchy package, out from internal.BaseModule

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@azidar azidar requested a review from jackkoenig April 15, 2022 22:35
@azidar azidar added this to the 3.6.0 milestone Apr 15, 2022
@azidar azidar enabled auto-merge (squash) April 15, 2022 22:57
@azidar azidar merged commit 5791ff0 into master Apr 15, 2022
@azidar azidar deleted the move-clones branch April 15, 2022 23:52
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants