Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AffectsChiselPrefix test #2693

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

jared-barocsi
Copy link
Contributor

Meant to compliment #2610: AffectsChiselPrefix was originally indirectly tested in NamingAnnotationTest, however most of these tests will be removed along with @chiselName. This PR adds the necessary code to directly test AffectsChiselPrefix's behavior.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code refactoring
  • code cleanup

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

Squash and merge

Release Notes

Adds AffectsChiselPrefix tests which were previously missing

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added this to the 3.5.x milestone Aug 23, 2022
@jackkoenig jackkoenig merged commit 1a23b42 into chipsalliance:master Aug 23, 2022
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
@mergify mergify bot added the Backported This PR has been backported label Aug 23, 2022
mergify bot added a commit that referenced this pull request Aug 23, 2022
(cherry picked from commit 1a23b42)

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported This PR has been backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants