Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexical scope checks to Assert, Assume and Printf #2706

Merged
merged 11 commits into from
Sep 29, 2022
Merged

Add lexical scope checks to Assert, Assume and Printf #2706

merged 11 commits into from
Sep 29, 2022

Commits on Sep 27, 2022

  1. Add scope checks to assert, assume and printf

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a2bf3ca View commit details
    Browse the repository at this point in the history

  2. Update scope checks to recursively check scope of Printable Data

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    09b60d2 View commit details
    Browse the repository at this point in the history

  3. Update printf tests

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    9889386 View commit details
    Browse the repository at this point in the history

  4. Code review updates 

    Move checkScope to object Printable and update callsites
    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1985a91 View commit details
    Browse the repository at this point in the history

  5. Change assertTesterPasses to elaborate for negative tests

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1b2a3cc View commit details
    Browse the repository at this point in the history

  6. Remove unused val

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    e5161ad View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Jack Koenig <jack.koenig3@gmail.com>
    @adkian-sifive @jackkoenig
    adkian-sifive and jackkoenig committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    127f7b9 View commit details
    Browse the repository at this point in the history

  8. Change map to foreach

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    ba9642b View commit details
    Browse the repository at this point in the history

  9. Update checkScope signature and callsites

    @adkian-sifive
    adkian-sifive committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    1525a1e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Clean up BasicTester tests

    @adkian-sifive
    adkian-sifive committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    95f8b47 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Fix broken tests

    @adkian-sifive
    adkian-sifive committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    306619b View commit details
    Browse the repository at this point in the history