Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LTL] Fix verif_* -- these are statements not expressions, no ret value. #4061

Merged
merged 1 commit into from
May 7, 2024

Conversation

dtzSiFive
Copy link
Member

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Fix LTL verif statements.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@dtzSiFive dtzSiFive added the Bugfix Fixes a bug, will be included in release notes label May 7, 2024
@dtzSiFive dtzSiFive added this to the 7.0 milestone May 7, 2024
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this change, we should maybe make them expressions in the same sense chisel3.assert is so that labels can operate with Chisel naming behavior, same convo as #4001 (comment).

@jackkoenig jackkoenig enabled auto-merge (squash) May 7, 2024 19:09
@jackkoenig jackkoenig disabled auto-merge May 7, 2024 19:09
@jackkoenig jackkoenig changed the title [LTL] Fix verif_* -- these are staements not expressions, no ret value. [LTL] Fix verif_* -- these are statements not expressions, no ret value. May 7, 2024
@dtzSiFive dtzSiFive merged commit 57ab601 into chipsalliance:main May 7, 2024
18 checks passed
@dtzSiFive dtzSiFive deleted the fix/ltl-verif-no-ret branch May 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Fixes a bug, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants