TLBusWrapper: for internal wire name stability, genericize inner coupler port name #2515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated signal names for diplomatically punched wires can contain the name of the node to which they are connected. While this behavior is informative in some cases, in other cases it represents a "leak" in terms of the contents of a child module becoming visible to a parent scope. One common case of this undesirable aspect of the behavior is the point at which
TLBusWrapper
"coupler scopes" are connected to the crossbar module within the BusWrapper. The child scope is usually productively named after the device it is connected to, and there is no added value in the specific adapters that happen to be used inside a particular coupler configuration being made apparent via the wire names internal to the wrapper, it's just another source of possible verilog diff mismatches across versions, or between configurations when e.g. a particular kind of clock crossing is inserted (or not).Instead, we now just ensure that the signal name prefix for such connections is always
tl
. See examples below.Type of change: other enhancement
Impact: change to some internal verilog signal names
Development Phase: implementation
Some Representative Verilog diffs