Make 8 more tests runnable multiple times via run_test.py #6791

onurctirtir · 2023-03-24T10:17:43Z

Soon I will be doing some changes related to #692 in router planner
and those changes require updating ~5/6 tests related to router
planning. And to make those test files runnable by run_test.py
multiple times, we need to make some other tests (that they're
run in parallel / they badly depend on) ready for run_test.py too.

JelteF · 2023-03-24T10:20:23Z

src/test/regress/expected/multi_data_types.out

 DROP TABLE composite_type_partitioned_table;
 DROP TABLE bugs;
 DROP TABLE varchar_hash_partitioned_table;
+-- drop all the types created in this test, at once
+SET client_min_messages TO WARNING;
+DROP TYPE test_composite_type, other_composite_type, bug_status CASCADE;
+DROP OPERATOR FAMILY cats_op_fam USING hash;


I think it's nicer to change this test so it uses a dedicated schema instead. I see you did that for another test. Is that not possible for this one for some reason?

Well, this is because dropping a schema that has tables that depend on such composite types was causing bad errors due to #5780, so I didn't spend much time to create them in a schema.

Probably good to add a code comment that we're not using a schema here because of #5780, so any future refactoring attempts don't run into the same issue.

moved this up in the file and added some explanation on why I did so

JelteF · 2023-03-24T10:23:43Z

src/test/regress/sql/multi_mx_modifying_xacts.sql

@@ -207,6 +207,11 @@ CREATE FUNCTION reject_bad_mx() RETURNS trigger AS $rb$
 $rb$ LANGUAGE plpgsql;
 RESET citus.enable_metadata_sync;

+BEGIN;
+  SET local client_min_messages TO WARNING;
+  DROP TRIGGER IF EXISTS reject_bad_mx ON objects_mx_1220103;


Why are these still left around at this point? Is that from the previous run of this test? If so, can we remove them at the end of the test file instead?

yeah we can drop them at the end of the file

Looked into that little more and I guess we can't do that because the tables seem to have replication_factor > 1 and that's why the same create trigger command (on shard) complains about that the trigger already exists even if we run this test file once.

Though I don't know why this wasn't the case before ..

Looked into that little more and I guess we can't do that because the tables seem to have replication_factor > 1 and that's why the same create trigger command (on shard) complains about that the trigger already exists even if we run this test file once.

Though I don't know why this wasn't the case before ..

I don't what I was thinking / why but nvm, fixed that as well :)

JelteF · 2023-03-24T10:32:43Z

src/test/regress/sql/multi_upsert.sql

+BEGIN;
+  SET local client_min_messages TO WARNING;
+  DROP TABLE IF EXISTS upsert_test, upsert_test_2, upsert_test_3, upsert_test_4, dropcol_distributed;
+COMMIT;


Again let's use a schema if possible, and otherwise drop these at the end of the file instead.

JelteF · 2023-03-24T10:36:54Z

src/test/regress/sql/multi_tenant_isolation.sql

+BEGIN;
+  SET local client_min_messages TO WARNING;
+  DROP SCHEMA IF EXISTS  "Tenant Isolation" CASCADE;
+  DROP TYPE IF EXISTS test_composite_type CASCADE;
+COMMIT;


Can this be moved to the end of the file instead? Also it seems like the schema is already dropped there at line 614

unfortunately no because multi_tenant_isolation_nonblocking depends on the schema created here

multi_tenant_isolation_nonblocking creates the schema itself too afaict, which makes sense because it is dropped at line 614

oh this is corect

JelteF · 2023-03-24T10:54:06Z

src/test/regress/sql/multi_simple_queries.sql

 DROP SEQUENCE query_seq;
+DROP TABLE articles, authors, articles_single_shard;


Is using a schema not possible here?

JelteF · 2023-03-24T10:54:52Z

src/test/regress/sql/multi_mx_router_planner.sql

+BEGIN;
+  SET local client_min_messages TO WARNING;
+  DROP MATERIALIZED VIEW IF EXISTS mv_articles_hash_mx_error;
+COMMIT;


Let's drop this at the end if possible, or preferably use a schema. And otherwise add a comment why it cannot be done at the end.

JelteF · 2023-03-24T10:55:06Z

src/test/regress/sql/multi_mx_router_planner.sql

+BEGIN;
+  SET local client_min_messages TO WARNING;
+  DROP TABLE IF EXISTS authors_hash_mx;
+COMMIT;


Let's drop this at the end if possible, or preferably use a schema. And otherwise add a comment why it cannot be done at the end.

codecov · 2023-03-24T12:22:16Z

Codecov Report

Merging #6791 (24603b3) into main (da7db53) will increase coverage by 18.66%.
The diff coverage is n/a.

❗ Current head 24603b3 differs from pull request most recent head a60398c. Consider uploading reports for the commit a60398c to get more accurate results

@@             Coverage Diff             @@
##             main    #6791       +/-   ##
===========================================
+ Coverage   74.49%   93.15%   +18.66%     
===========================================
  Files         260      260               
  Lines       56129    56138        +9     
===========================================
+ Hits        41811    52297    +10486     
+ Misses      14318     3841    -10477

JelteF · 2023-03-27T08:36:20Z

src/test/regress/sql/multi_router_planner.sql

@@ -929,7 +929,7 @@ UPDATE pg_dist_shard SET shardmaxvalue = 100, shardminvalue=1 WHERE shardid = :s

 -- we execute the query within a function to consolidate the error messages
 -- between different executors
-CREATE FUNCTION raise_failed_execution_router(query text) RETURNS void AS $$
+CREATE OR REPLACE FUNCTION raise_failed_execution_router(query text) RETURNS void AS $$


I guess this means it wasn't dropped at the end of the file. Let's do that instead, and preferably with a schema drop.

yeah, fixed that as well

JelteF · 2023-03-27T08:39:05Z

src/test/regress/sql/multi_mx_router_planner.sql

+DROP MATERIALIZED VIEW mv_articles_hash_mx_error;
+DROP TABLE authors_hash_mx;


Any reason not to do a schema drop instead?

because this test file mostly uses the tables created in multi_mx_create_table.sql, such as articles_single_shard_hash_mx

In this release, I tried something different. I experimented with adding the PR number and title to the changelog right before each changelog entry. This way, it is easier to track where a particular changelog entry comes from. After reviews are over, I plan to remove those lines with PR numbers and titles. I went through all the PRs that are merged after 11.2.0 release and came up with a list of PRs that may need help with changelog entries. You can see details on PRs grouped in several sections below. ## PRs with missing entries The following PRs below do not have a changelog entry. If you think that this is a mistake, please share it in this PR along with a suggestion on what the changelog item should be. PR #6846 : fix 3 flaky tests in failure schedule PR #6844 : Add CPU usage to citus_stat_tenants PR #6833 : Fix citus_stat_tenants period updating bug PR #6787 : Add more tests for ddl coverage PR #6842 : Add build-cdc-* temporary directories to .gitignore PR #6841 : Add build-cdc-* temporary directories to .gitignore PR #6840 : Bump Citus to 12.0devel PR #6824 : Fixes flakiness in multi_metadata_sync test PR #6811 : Backport identity column improvements to v11.2 PR #6830 : In run_test.py actually return worker_count PR #6825 : Fixes flakiness in multi_cluster_management test PR #6816 : Refactor run_test.py PR #6817 : Explicitly disallow local rels when inserting into dist table PR #6821 : Rename citus stats tenants PR #6822 : Add some more tests for initial sql support PR #6819 : Fix flakyness in citus_split_shard_by_split_points_deferred_drop PR #6814 : Make python-regress based tests runnable with run_test.py PR #6813 : Fix flaky multi_mx_schema_support test PR #6720 : Convert columnar tap tests to pytest PR #6812 : Revoke statistics permissions from public and grant them to pg_monitor PR #6769 : Citus stats tenants guc PR #6807 : Fix the incorrect (constant) value passed to pointer-to-bool parameter, pass a NULL as the value is not used PR #6797 : Attribute local queries and cached plans on local execution PR #6796 : Parse the annotation string correctly PR #6762 : Add logs to citus_stats_tenants PR #6773 : Add initial sql support for distributed tables that don't have a shard key PR #6792 : Disentangle MERGE planning code from the modify-planning code path PR #6761 : Citus stats tenants collector view PR #6791 : Make 8 more tests runnable multiple times via run_test.py PR #6786 : Refactor some of the planning code to accommodate a new planning path for MERGE SQL PR #6789 : Rename AllRelations.. functions to AllDistributedRelations.. PR #6788 : Actually skip arbitrary_configs_router & nested_execution for AllNullDistKeyDefaultConfig PR #6783 : Add a config for arbitrary config tests where all the tables are null-shard-key tables PR #6784 : Fix attach partition: citus local to null distributed PR #6782 : Add an arbitrary config test heavily based on multi_router_planner_fast_path.sql PR #6781 : Decide what to do with router planner error at one place PR #6778 : Support partitioning for dist tables with null dist keys PR #6766 : fix pip lock file PR #6764 : Make workerCount configurable for regression tests PR #6745 : Add support for creating distributed tables with a null shard key PR #6696 : This implements MERGE phase-III PR #6767 : Add pytest depedencies to Pipfile PR #6760 : Decide core distribution params in CreateCitusTable PR #6759 : Add multi_create_fdw into minimal_schedule PR #6743 : Replace CITUS_TABLE_WITH_NO_DIST_KEY checks with HasDistributionKey() PR #6751 : Stabilize single_node.sql and others that report illegal node removal PR #6742 : Refactor CreateDistributedTable() PR #6747 : Remove unused lock functions PR #6744 : Fix multiple output version arbitrary config tests PR #6741 : Stabilize single node tests PR #6740 : Fix string eval bug in migration files check PR #6736 : Make run_test.py and create_test.py importable without errors PR #6734 : Don't blanket ignore flake8 E402 error PR #6737 : Fixes bookworm packaging pipeline problem PR #6735 : Fix run_test.py on python 3.9 PR #6733 : MERGE: In deparser, add missing check for RETURNING clause. PR #6714 : Remove auto_explain workaround in citus explain hook for ALTER TABLE PR #6719 : Fix flaky test PR #6718 : Add more powerfull dependency tracking to run_test.py PR #6710 : Install non-vulnerable cryptography package PR #6711 : Support compilation and run tests on latest PG versions PR #6700 : Add auto-formatting and linting to our python code PR #6707 : Allow multi_insert_select to run repeatably PR #6708 : Fix flakyness in failure_create_distributed_table_non_empty PR #6698 : Miscellaneous cleanup PR #6704 : Update README for 11.2 PR #6703 : Fix dubious ownership error from git PR #6690 : Bump Citus to 11.3devel ## Too long changelog entries The following PRs have changelog entries that are too long to fit in a single line. I'd expect authors to supply at changelog entries in `DESCRIPTION:` lines that are at most 78 characters. If you want to supply multi-line changelog items, you can have multiple lines that start with `DESCRIPTION:` instead. PR #6837 : fixes update propagation bug when `citus_set_coordinator_host` is called more than once PR #6738 : Identity column implementation refactorings PR #6756 : Schedule parallel shard moves in background rebalancer by removing task dependencies between shard moves across colocation groups. PR #6793 : Add a GUC to disallow planning the queries that reference non-colocated tables via router planner PR #6726 : fix memory leak during altering distributed table with a lot of partition and shards PR #6722 : fix memory leak during distribution of a table with a lot of partitions PR #6693 : prevent memory leak during ConvertTable with a lot of partitions ## Empty changelog entries. The following PR had an empty `DESCRIPTION:` line. This generates an empty changelog line that needs to be removed manually. Please either provide a short entry, or remove `DESCRIPTION:` line completely. PR #6810 : Make CDC decoder an independent extension PR #6827 : Makefile changes to build CDC in builddir for pgoutput and wal2json. --------- Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>

In this release, I tried something different. I experimented with adding the PR number and title to the changelog right before each changelog entry. This way, it is easier to track where a particular changelog entry comes from. After reviews are over, I plan to remove those lines with PR numbers and titles. I went through all the PRs that are merged after 11.2.0 release and came up with a list of PRs that may need help with changelog entries. You can see details on PRs grouped in several sections below. The following PRs below do not have a changelog entry. If you think that this is a mistake, please share it in this PR along with a suggestion on what the changelog item should be. PR #6846 : fix 3 flaky tests in failure schedule PR #6844 : Add CPU usage to citus_stat_tenants PR #6833 : Fix citus_stat_tenants period updating bug PR #6787 : Add more tests for ddl coverage PR #6842 : Add build-cdc-* temporary directories to .gitignore PR #6841 : Add build-cdc-* temporary directories to .gitignore PR #6840 : Bump Citus to 12.0devel PR #6824 : Fixes flakiness in multi_metadata_sync test PR #6811 : Backport identity column improvements to v11.2 PR #6830 : In run_test.py actually return worker_count PR #6825 : Fixes flakiness in multi_cluster_management test PR #6816 : Refactor run_test.py PR #6817 : Explicitly disallow local rels when inserting into dist table PR #6821 : Rename citus stats tenants PR #6822 : Add some more tests for initial sql support PR #6819 : Fix flakyness in citus_split_shard_by_split_points_deferred_drop PR #6814 : Make python-regress based tests runnable with run_test.py PR #6813 : Fix flaky multi_mx_schema_support test PR #6720 : Convert columnar tap tests to pytest PR #6812 : Revoke statistics permissions from public and grant them to pg_monitor PR #6769 : Citus stats tenants guc PR #6807 : Fix the incorrect (constant) value passed to pointer-to-bool parameter, pass a NULL as the value is not used PR #6797 : Attribute local queries and cached plans on local execution PR #6796 : Parse the annotation string correctly PR #6762 : Add logs to citus_stats_tenants PR #6773 : Add initial sql support for distributed tables that don't have a shard key PR #6792 : Disentangle MERGE planning code from the modify-planning code path PR #6761 : Citus stats tenants collector view PR #6791 : Make 8 more tests runnable multiple times via run_test.py PR #6786 : Refactor some of the planning code to accommodate a new planning path for MERGE SQL PR #6789 : Rename AllRelations.. functions to AllDistributedRelations.. PR #6788 : Actually skip arbitrary_configs_router & nested_execution for AllNullDistKeyDefaultConfig PR #6783 : Add a config for arbitrary config tests where all the tables are null-shard-key tables PR #6784 : Fix attach partition: citus local to null distributed PR #6782 : Add an arbitrary config test heavily based on multi_router_planner_fast_path.sql PR #6781 : Decide what to do with router planner error at one place PR #6778 : Support partitioning for dist tables with null dist keys PR #6766 : fix pip lock file PR #6764 : Make workerCount configurable for regression tests PR #6745 : Add support for creating distributed tables with a null shard key PR #6696 : This implements MERGE phase-III PR #6767 : Add pytest depedencies to Pipfile PR #6760 : Decide core distribution params in CreateCitusTable PR #6759 : Add multi_create_fdw into minimal_schedule PR #6743 : Replace CITUS_TABLE_WITH_NO_DIST_KEY checks with HasDistributionKey() PR #6751 : Stabilize single_node.sql and others that report illegal node removal PR #6742 : Refactor CreateDistributedTable() PR #6747 : Remove unused lock functions PR #6744 : Fix multiple output version arbitrary config tests PR #6741 : Stabilize single node tests PR #6740 : Fix string eval bug in migration files check PR #6736 : Make run_test.py and create_test.py importable without errors PR #6734 : Don't blanket ignore flake8 E402 error PR #6737 : Fixes bookworm packaging pipeline problem PR #6735 : Fix run_test.py on python 3.9 PR #6733 : MERGE: In deparser, add missing check for RETURNING clause. PR #6714 : Remove auto_explain workaround in citus explain hook for ALTER TABLE PR #6719 : Fix flaky test PR #6718 : Add more powerfull dependency tracking to run_test.py PR #6710 : Install non-vulnerable cryptography package PR #6711 : Support compilation and run tests on latest PG versions PR #6700 : Add auto-formatting and linting to our python code PR #6707 : Allow multi_insert_select to run repeatably PR #6708 : Fix flakyness in failure_create_distributed_table_non_empty PR #6698 : Miscellaneous cleanup PR #6704 : Update README for 11.2 PR #6703 : Fix dubious ownership error from git PR #6690 : Bump Citus to 11.3devel The following PRs have changelog entries that are too long to fit in a single line. I'd expect authors to supply at changelog entries in `DESCRIPTION:` lines that are at most 78 characters. If you want to supply multi-line changelog items, you can have multiple lines that start with `DESCRIPTION:` instead. PR #6837 : fixes update propagation bug when `citus_set_coordinator_host` is called more than once PR #6738 : Identity column implementation refactorings PR #6756 : Schedule parallel shard moves in background rebalancer by removing task dependencies between shard moves across colocation groups. PR #6793 : Add a GUC to disallow planning the queries that reference non-colocated tables via router planner PR #6726 : fix memory leak during altering distributed table with a lot of partition and shards PR #6722 : fix memory leak during distribution of a table with a lot of partitions PR #6693 : prevent memory leak during ConvertTable with a lot of partitions The following PR had an empty `DESCRIPTION:` line. This generates an empty changelog line that needs to be removed manually. Please either provide a short entry, or remove `DESCRIPTION:` line completely. PR #6810 : Make CDC decoder an independent extension PR #6827 : Makefile changes to build CDC in builddir for pgoutput and wal2json. --------- Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com> (cherry picked from commit 9344300)

In this release, I tried something different. I experimented with adding the PR number and title to the changelog right before each changelog entry. This way, it is easier to track where a particular changelog entry comes from. After reviews are over, I plan to remove those lines with PR numbers and titles. I went through all the PRs that are merged after 11.2.0 release and came up with a list of PRs that may need help with changelog entries. You can see details on PRs grouped in several sections below. ## PRs with missing entries The following PRs below do not have a changelog entry. If you think that this is a mistake, please share it in this PR along with a suggestion on what the changelog item should be. PR #6846 : fix 3 flaky tests in failure schedule PR #6844 : Add CPU usage to citus_stat_tenants PR #6833 : Fix citus_stat_tenants period updating bug PR #6787 : Add more tests for ddl coverage PR #6842 : Add build-cdc-* temporary directories to .gitignore PR #6841 : Add build-cdc-* temporary directories to .gitignore PR #6840 : Bump Citus to 12.0devel PR #6824 : Fixes flakiness in multi_metadata_sync test PR #6811 : Backport identity column improvements to v11.2 PR #6830 : In run_test.py actually return worker_count PR #6825 : Fixes flakiness in multi_cluster_management test PR #6816 : Refactor run_test.py PR #6817 : Explicitly disallow local rels when inserting into dist table PR #6821 : Rename citus stats tenants PR #6822 : Add some more tests for initial sql support PR #6819 : Fix flakyness in citus_split_shard_by_split_points_deferred_drop PR #6814 : Make python-regress based tests runnable with run_test.py PR #6813 : Fix flaky multi_mx_schema_support test PR #6720 : Convert columnar tap tests to pytest PR #6812 : Revoke statistics permissions from public and grant them to pg_monitor PR #6769 : Citus stats tenants guc PR #6807 : Fix the incorrect (constant) value passed to pointer-to-bool parameter, pass a NULL as the value is not used PR #6797 : Attribute local queries and cached plans on local execution PR #6796 : Parse the annotation string correctly PR #6762 : Add logs to citus_stats_tenants PR #6773 : Add initial sql support for distributed tables that don't have a shard key PR #6792 : Disentangle MERGE planning code from the modify-planning code path PR #6761 : Citus stats tenants collector view PR #6791 : Make 8 more tests runnable multiple times via run_test.py PR #6786 : Refactor some of the planning code to accommodate a new planning path for MERGE SQL PR #6789 : Rename AllRelations.. functions to AllDistributedRelations.. PR #6788 : Actually skip arbitrary_configs_router & nested_execution for AllNullDistKeyDefaultConfig PR #6783 : Add a config for arbitrary config tests where all the tables are null-shard-key tables PR #6784 : Fix attach partition: citus local to null distributed PR #6782 : Add an arbitrary config test heavily based on multi_router_planner_fast_path.sql PR #6781 : Decide what to do with router planner error at one place PR #6778 : Support partitioning for dist tables with null dist keys PR #6766 : fix pip lock file PR #6764 : Make workerCount configurable for regression tests PR #6745 : Add support for creating distributed tables with a null shard key PR #6696 : This implements MERGE phase-III PR #6767 : Add pytest depedencies to Pipfile PR #6760 : Decide core distribution params in CreateCitusTable PR #6759 : Add multi_create_fdw into minimal_schedule PR #6743 : Replace CITUS_TABLE_WITH_NO_DIST_KEY checks with HasDistributionKey() PR #6751 : Stabilize single_node.sql and others that report illegal node removal PR #6742 : Refactor CreateDistributedTable() PR #6747 : Remove unused lock functions PR #6744 : Fix multiple output version arbitrary config tests PR #6741 : Stabilize single node tests PR #6740 : Fix string eval bug in migration files check PR #6736 : Make run_test.py and create_test.py importable without errors PR #6734 : Don't blanket ignore flake8 E402 error PR #6737 : Fixes bookworm packaging pipeline problem PR #6735 : Fix run_test.py on python 3.9 PR #6733 : MERGE: In deparser, add missing check for RETURNING clause. PR #6714 : Remove auto_explain workaround in citus explain hook for ALTER TABLE PR #6719 : Fix flaky test PR #6718 : Add more powerfull dependency tracking to run_test.py PR #6710 : Install non-vulnerable cryptography package PR #6711 : Support compilation and run tests on latest PG versions PR #6700 : Add auto-formatting and linting to our python code PR #6707 : Allow multi_insert_select to run repeatably PR #6708 : Fix flakyness in failure_create_distributed_table_non_empty PR #6698 : Miscellaneous cleanup PR #6704 : Update README for 11.2 PR #6703 : Fix dubious ownership error from git PR #6690 : Bump Citus to 11.3devel ## Too long changelog entries The following PRs have changelog entries that are too long to fit in a single line. I'd expect authors to supply at changelog entries in `DESCRIPTION:` lines that are at most 78 characters. If you want to supply multi-line changelog items, you can have multiple lines that start with `DESCRIPTION:` instead. PR #6837 : fixes update propagation bug when `citus_set_coordinator_host` is called more than once PR #6738 : Identity column implementation refactorings PR #6756 : Schedule parallel shard moves in background rebalancer by removing task dependencies between shard moves across colocation groups. PR #6793 : Add a GUC to disallow planning the queries that reference non-colocated tables via router planner PR #6726 : fix memory leak during altering distributed table with a lot of partition and shards PR #6722 : fix memory leak during distribution of a table with a lot of partitions PR #6693 : prevent memory leak during ConvertTable with a lot of partitions ## Empty changelog entries. The following PR had an empty `DESCRIPTION:` line. This generates an empty changelog line that needs to be removed manually. Please either provide a short entry, or remove `DESCRIPTION:` line completely. PR #6810 : Make CDC decoder an independent extension PR #6827 : Makefile changes to build CDC in builddir for pgoutput and wal2json. --------- Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>

onurctirtir requested review from JelteF and removed request for JelteF March 24, 2023 10:17

JelteF reviewed Mar 24, 2023

View reviewed changes

onurctirtir force-pushed the get-ready-legacy-router-tests branch 3 times, most recently from f2a536a to 8fe088b Compare March 24, 2023 10:44

JelteF reviewed Mar 24, 2023

View reviewed changes

onurctirtir force-pushed the get-ready-legacy-router-tests branch 3 times, most recently from 6df577f to 908df6d Compare March 24, 2023 11:41

onurctirtir changed the title ~~Make 8 more tests runnable multiple times via run_test.py~~ Make 11 more tests runnable multiple times via run_test.py Mar 24, 2023

onurctirtir force-pushed the get-ready-legacy-router-tests branch from 908df6d to 29ed558 Compare March 24, 2023 12:08

onurctirtir changed the title ~~Make 11 more tests runnable multiple times via run_test.py~~ Make 8 more tests runnable multiple times via run_test.py Mar 24, 2023

onurctirtir force-pushed the get-ready-legacy-router-tests branch from 29ed558 to cab2aed Compare March 24, 2023 12:12

onurctirtir requested a review from JelteF March 24, 2023 12:38

onurctirtir enabled auto-merge (squash) March 24, 2023 12:45

onurctirtir force-pushed the get-ready-legacy-router-tests branch from cab2aed to 24603b3 Compare March 27, 2023 08:15

JelteF reviewed Mar 27, 2023

View reviewed changes

c

a60398c

onurctirtir force-pushed the get-ready-legacy-router-tests branch from 24603b3 to a60398c Compare March 27, 2023 09:01

JelteF approved these changes Mar 27, 2023

View reviewed changes

onurctirtir merged commit 372a93b into main Mar 27, 2023

onurctirtir deleted the get-ready-legacy-router-tests branch March 27, 2023 09:19

hanefi mentioned this pull request Apr 14, 2023

Changelog entries for 11.3.0 #6856

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make 8 more tests runnable multiple times via run_test.py #6791

Make 8 more tests runnable multiple times via run_test.py #6791

onurctirtir commented Mar 24, 2023

JelteF Mar 24, 2023 •

edited

Loading

onurctirtir Mar 24, 2023

JelteF Mar 24, 2023 •

edited

Loading

onurctirtir Mar 24, 2023 •

edited

Loading

JelteF Mar 24, 2023

onurctirtir Mar 24, 2023

onurctirtir Mar 24, 2023

onurctirtir Mar 27, 2023

JelteF Mar 24, 2023

JelteF Mar 24, 2023

onurctirtir Mar 24, 2023

JelteF Mar 24, 2023 •

edited

Loading

onurctirtir Mar 24, 2023

JelteF Mar 24, 2023

JelteF Mar 24, 2023 •

edited

Loading

JelteF Mar 24, 2023 •

edited

Loading

codecov bot commented Mar 24, 2023 •

edited

Loading

JelteF Mar 27, 2023

onurctirtir Mar 27, 2023

JelteF Mar 27, 2023

onurctirtir Mar 27, 2023

		DROP SEQUENCE query_seq;
		DROP TABLE articles, authors, articles_single_shard;

		DROP MATERIALIZED VIEW mv_articles_hash_mx_error;
		DROP TABLE authors_hash_mx;

Make 8 more tests runnable multiple times via run_test.py #6791

Make 8 more tests runnable multiple times via run_test.py #6791

Conversation

onurctirtir commented Mar 24, 2023

JelteF Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JelteF Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

onurctirtir Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JelteF Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JelteF Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

JelteF Mar 24, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Mar 24, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JelteF Mar 24, 2023 •

edited

Loading

JelteF Mar 24, 2023 •

edited

Loading

onurctirtir Mar 24, 2023 •

edited

Loading

JelteF Mar 24, 2023 •

edited

Loading

JelteF Mar 24, 2023 •

edited

Loading

JelteF Mar 24, 2023 •

edited

Loading

codecov bot commented Mar 24, 2023 •

edited

Loading