Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #174

Merged
merged 24 commits into from
Feb 25, 2020
Merged

Python 3 support #174

merged 24 commits into from
Feb 25, 2020

Conversation

amercader
Copy link
Member

Includes the great work from @smotornyuk on #171, plus

  • fixes
  • New pytest based test suite
  • Updated Travis setup

Tests on CKAN 2.9 / Python 3 fail because ckanext-harvest has not been ported yet.

smotornyuk and others added 11 commits January 6, 2020 18:37
To run against CKAN 2.9. Old nose tests for CKAN <= 2.8 have been moved
to the nose folder
On CKAN 2.9 tests are run in py3 and py2, and the pytest suite is run
instead of nose

Tests on py3 fail because ckanext-harvest has not been ported
@amercader amercader mentioned this pull request Feb 22, 2020
Closed
@amercader
Copy link
Member Author

@metaodi @seitenbau-govdata I'm going to merge this as I need to use it as a reference for other extension py3 migrations but please flag any comments you find in the future.

You will notice that there are two test suites, the one in the tests/nose folder is the one you know, and it targets CKAN <= 2.8. The new default one is the one in the tests folder, based on pytest. From now on we'll need to add tests on both suites (we might work on a unified backwards compatible suite in the future)

@amercader amercader merged commit ca0d818 into master Feb 25, 2020
@seitenbau-govdata
Copy link
Member

@amercader I know I'm a little bit late...😃 Thanks a lot. Great work!

@amercader
Copy link
Member Author

Thanks @seitenbau-govdata !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants