Skip to content

Conversation

@efernandez
Copy link
Member

This PR is on top of #24

This fixes an issue with the default values that get assigned to the static param that are also defined as dynamic params:

  • When one of this params is not defined in the param server, the default value is taken from the cfg file, not the default used in the constructor.
  • When one of this params is on the param server, dynamic reconfigure takes it.
  • This PR changes the default values in the constructor with the defaults from the cfg file,
  • and updates the defaults of cfg to better defaults

This PR also fixes some minor issues (in a separate commit).

@afakihcpr @mikepurvis

@efernandez efernandez mentioned this pull request Jan 29, 2016
@efernandez efernandez force-pushed the change_covariance_model branch 3 times, most recently from 8a44c4d to e264c15 Compare January 29, 2016 05:48
@efernandez efernandez force-pushed the use_dynamic_params_defaults branch from 5539c5d to d66d6c8 Compare January 29, 2016 05:50
@efernandez efernandez force-pushed the change_covariance_model branch 4 times, most recently from dc38d7f to 1c84222 Compare February 8, 2016 16:36
Enrique Fernández Perdomo added 11 commits February 8, 2016 14:02
Create linear/quadratic meas cov model classes
This way we can have position increment (dp) and velocity (v) from the
actual position and velocity, or estimated from velocity and position,
respectively.
This got broken after the 'Use control period on updates' commit.
@efernandez efernandez force-pushed the use_dynamic_params_defaults branch from d66d6c8 to d109b0c Compare February 8, 2016 23:08
@efernandez
Copy link
Member Author

Closing and creating on top of indigo-devel

@efernandez efernandez closed this Feb 8, 2016
@efernandez efernandez deleted the use_dynamic_params_defaults branch February 10, 2016 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants