fix: aws terraform-tests performance_insights_retention_period #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#187103734](https://www.pivotaltracker.com/story/show/187103734) Recently, a new PR for validating this property was merged: hashicorp/terraform-provider-aws#35870 I believe it's valuable to have our tests break when changes like this are introduced in the providers. Therefore, we should try have behaviours such as this encoded in our tests. Things like: "invalid values for property X are not validated by TF".
fnaranjo-vmw
force-pushed
the
fix-performance-insights-retention-period-#187103734
branch
from
5ccf70d
to
ef9c9c9
Compare
fnaranjo-vmw
deleted the
fix-performance-insights-retention-period-#187103734
branch
fnaranjo-vmw
added a commit
that referenced
this pull request
Feb 27, 2024
[#187061563](https://www.pivotaltracker.com/story/show/187061563) Related PRs: - #1600 By adding this test, if such validation ever gets implemented in the provider we'll know it since the test will start failing as happened for: #1597
5 tasks
fnaranjo-vmw
added a commit
that referenced
this pull request
Feb 27, 2024
* fix: test fifo properties are validated by the IAAS not TF [#187061563](https://www.pivotaltracker.com/story/show/187061563) Related PRs: - #1600 By adding this test, if such validation ever gets implemented in the provider we'll know it since the test will start failing as happened for: #1597 * Remove failing assertions These assertions were added in the following PR, but they are make the pipeline fail (probably because those fields are not explicitly null but empty instead) #1600 --------- Co-authored-by: Felisia Martini <fmartini@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187103734
Recently, a new PR for validating this property was merged: hashicorp/terraform-provider-aws#35870
I believe it's valuable to have our tests break when changes like this are introduced in the providers. Therefore, we should try have behaviours such as this encoded in our tests. Things like: "invalid values for property X are not validated by TF".
Checklist:
make run-integration-testsandmake run-terraform-tests?