fix: Fifo properties should only be set if the queue is of type FIFO #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`deduplication_scope` and `fifo_throughput_limit` do not apply for standard queues and they will throw error if attempted to be set (e.g. because there is a default)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187123855 The labels on this github issue will be updated when the story is started. |
| ) | ||
| }) | ||
|
|
||
| It("should create a FIFO SQS queue for high throughput mode", func() { |
There was a problem hiding this comment.
nitpick: I noticed this is not a new test. It looks like it was simply moved to a different Context block.
I would have tried to make the diffing reflect this. If not possible, I usually prefer creating a different PR or commit only for "reformatting".
I usually do this to distinguish between the absolute minimum changes, and the opportunistic improvements (which are always more than welcome).
Leaving that aside, thank you for taking the time to organise the tests into a more sensible structure.
fnaranjo-vmw
added a commit
that referenced
this pull request
Feb 27, 2024
[#187061563](https://www.pivotaltracker.com/story/show/187061563) Related PRs: - #1600 By adding this test, if such validation ever gets implemented in the provider we'll know it since the test will start failing as happened for: #1597
5 tasks
FelisiaM
added a commit
that referenced
this pull request
Feb 27, 2024
These assertions were added in the following PR, but they are make the pipeline fail (probably because those fields are not explicitly null but empty instead) #1600
fnaranjo-vmw
added a commit
that referenced
this pull request
Feb 27, 2024
* fix: test fifo properties are validated by the IAAS not TF [#187061563](https://www.pivotaltracker.com/story/show/187061563) Related PRs: - #1600 By adding this test, if such validation ever gets implemented in the provider we'll know it since the test will start failing as happened for: #1597 * Remove failing assertions These assertions were added in the following PR, but they are make the pipeline fail (probably because those fields are not explicitly null but empty instead) #1600 --------- Co-authored-by: Felisia Martini <fmartini@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deduplication_scopeandfifo_throughput_limitdo not apply for standard queues and they will throw error if attempted to be set (e.g. because there is a default)Checklist:
make run-integration-testsandmake run-terraform-tests?