Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conifer header fix #247

Closed
wants to merge 9 commits into from
Closed

Conversation

Chriisbrown
Copy link

PR description:

Removes conifer header from TrackTrigger interface folder and fixes the buildfile to use the external conifer

PR validation:

This PR will most likely break our CI as it uses the conifer externals that have only just been added to cmsdist, however it will work when merged into central CMSSW

dally96 and others added 9 commits September 22, 2023 14:38
Co-authored-by: Daniel Ally <d.ally@cern.ch>
* Added phi region to TrackFit memory output.

* Added phi region of other seed stub.
* Check for new proj instead of new tracklet

* Ran code-format

* Back to tracklet, bool for first proj

---------

Co-authored-by: bryates <brent.yates@email.ucr.edu>
Co-authored-by: bryates <brent.yates@email.ucr.edu>
@Chriisbrown Chriisbrown requested a review from tomalin October 26, 2023 15:54
@tomalin
Copy link
Collaborator

tomalin commented Oct 26, 2023

This change should not be added here, but instead should be added to https://github.com/cms-L1TK/cmssw/tree/L1TK-PR-13_3_0_pre2 . The development branch will then automatically pick it up next time we branch it off from the latest CMSSW release. If we add it by hand to the development branch too, git may get confused.

@Chriisbrown Chriisbrown marked this pull request as draft October 27, 2023 08:48
@Chriisbrown Chriisbrown changed the base branch from L1TK-dev-13_3_0_pre2 to L1TK-PR-13_3_0_pre2 October 27, 2023 08:48
@Chriisbrown Chriisbrown deleted the conifer_header_fix branch October 27, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants