-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Pythia to 8.309 #8552
Update Pythia to 8.309 #8552
Conversation
A new Pull Request was created by @mseidel42 (Markus Seidel) for branch IB/CMSSW_13_2_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
Note that the current version in P8.240 branch still has the multiplicity bug. Just that we don't re-introduce this @mseidel42. |
please test |
-1 Failed Tests: Build BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory 32 | #include "Pythia8Plugins/PowhegHooksVincia.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory 32 | #include "Pythia8Plugins/PowhegHooksVincia.h" |
Ok, looks like this needs some changes in the Pythia8Hadronizer, the standard PowhegHooks should work for all parton showers now. For a possible 10_6 backport, I prepared the necessary changes here https://github.com/cms-externals/pythia8/compare/cms/240...mseidel42:pythia8:cms/240?expand=1 and wait for green light. |
@mseidel42 : can you link to the exact PR. I can't find a PR in 240 branch. |
Ok, I created one: cms-externals/pythia8#30 Probably to be discussed among interested parties in a GEN meeting. |
Ok, this needs to go with cms-sw/cmssw#42020 |
test parameters:
|
please test |
notes @DickyChant |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33246/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
please test rerun based on newer IB |
assign generators |
New categories assigned: generators @mkirsano,@menglu21,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks |
+1 |
@cms-sw/generators-l2 Can we move to 8.310 instead? It contains a fix for compilation with C++20. UPD. 8.310 is not yet released, my bad. Can we at least include the patch in the referenced issue? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33260/summary.html Comparison SummarySummary:
|
+externals |
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
Propose to update Pythia in master to 8.309 as it includes important fixes to the running of alpha_s:
Also discussed in today's GEN meeting: https://indico.cern.ch/event/1293969/contributions/5438463/attachments/2668515/4624955/GEN%20Meeting%20190623%20v2.pdf#page=16
The changes in our custom 8.306 were taken from the later Pythia versions, so they are all included.
@cms-sw/generators-l2 @amsimone FYI
@smrenna Would it be possible to get the patch fixing the alpha_s bug, so that we could consider a backport to 10_6 (https://github.com/cms-externals/pythia8/tree/cms/240)?