Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pythia to 8.309 #8552

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

mseidel42
Copy link
Contributor

Propose to update Pythia in master to 8.309 as it includes important fixes to the running of alpha_s:

Equation (9.5) in the 2006 RPP [Yao06] has erroneously been taken as a second-order alpha_strong expression, while actually it is a third-order one. This has been corrected, with separate second- and third-order options now available for matrix elements and showers. In practice the difference between second- and third-order running is minor, and furthermore first-order is default throughout.

Also discussed in today's GEN meeting: https://indico.cern.ch/event/1293969/contributions/5438463/attachments/2668515/4624955/GEN%20Meeting%20190623%20v2.pdf#page=16

The changes in our custom 8.306 were taken from the later Pythia versions, so they are all included.

@cms-sw/generators-l2 @amsimone FYI

@smrenna Would it be possible to get the patch fixing the alpha_s bug, so that we could consider a backport to 10_6 (https://github.com/cms-externals/pythia8/tree/cms/240)?

@mseidel42 mseidel42 changed the title Update pythia8.spec Update Pythia to 8.309 Jun 19, 2023
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mseidel42 (Markus Seidel) for branch IB/CMSSW_13_2_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@agrohsje
Copy link

Note that the current version in P8.240 branch still has the multiplicity bug. Just that we don't re-introduce this @mseidel42.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33240/summary.html
COMMIT: 00fff30
CMSSW: CMSSW_13_2_X_2023-06-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8552/33240/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory
   32 | #include "Pythia8Plugins/PowhegHooksVincia.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-06-19-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:32:10: fatal error: Pythia8Plugins/PowhegHooksVincia.h: No such file or directory
   32 | #include "Pythia8Plugins/PowhegHooksVincia.h"


@mseidel42
Copy link
Contributor Author

Ok, looks like this needs some changes in the Pythia8Hadronizer, the standard PowhegHooks should work for all parton showers now.

For a possible 10_6 backport, I prepared the necessary changes here https://github.com/cms-externals/pythia8/compare/cms/240...mseidel42:pythia8:cms/240?expand=1 and wait for green light.

@Saptaparna
Copy link

@mseidel42 : can you link to the exact PR. I can't find a PR in 240 branch.

@mseidel42
Copy link
Contributor Author

@mseidel42 : can you link to the exact PR. I can't find a PR in 240 branch.

Ok, I created one: cms-externals/pythia8#30

Probably to be discussed among interested parties in a GEN meeting.

@mseidel42
Copy link
Contributor Author

Ok, this needs to go with cms-sw/cmssw#42020

@smuzaffar
Copy link
Contributor

test parameters:

@smuzaffar
Copy link
Contributor

please test

@sihyunjeon
Copy link

notes @DickyChant

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33246/summary.html
COMMIT: 00fff30
CMSSW: CMSSW_13_2_X_2023-06-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8552/33246/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33246/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33246/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 131 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 59198 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195998
  • DQMHistoTests: Total failures: 268924
  • DQMHistoTests: Total nulls: 277
  • DQMHistoTests: Total successes: 2926775
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1135.7340000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11634.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 11834.0 ): -1.015 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12434.0,... ): 568.089 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0,... ): 0.492 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 250202.181 ): -0.404 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.553 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.164 KiB L1T/L1TStage2uGT
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 17 / 46 workflows

@smuzaffar
Copy link
Contributor

please test

rerun based on newer IB

@smuzaffar
Copy link
Contributor

assign generators

@cmsbuild
Copy link
Contributor

New categories assigned: generators

@mkirsano,@menglu21,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks

@menglu21
Copy link

+1

@iarspider
Copy link
Contributor

iarspider commented Jun 20, 2023

@cms-sw/generators-l2 Can we move to 8.310 instead? It contains a fix for compilation with C++20.

UPD. 8.310 is not yet released, my bad. Can we at least include the patch in the referenced issue?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-515b89/33260/summary.html
COMMIT: 00fff30
CMSSW: CMSSW_13_2_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8552/33260/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 45 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 59183 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197894
  • DQMHistoTests: Total failures: 270016
  • DQMHistoTests: Total nulls: 261
  • DQMHistoTests: Total successes: 2927595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1192.8780000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): -1.015 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 12434.0,... ): 596.989 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): -0.404 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.553 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 17 / 46 workflows

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants