Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Powheg+Vincia matching" #42020

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

mseidel42
Copy link
Contributor

This reverts commit 1c80a7d.

PR description:

Not needed anymore for Pythia 8.309:

The PowhegHooks now work with all three shower models and automatically switch between the simple shower, Vincia, and Dire based on the PartonShowers:model mode. In addition, the option to set POWHEG:nFinal = -1 has been ported from 8.244 to allow the use of event files with a variable number of real emissions.

cms-sw/cmsdist#8552

PR validation:

Compiles, should not affect any workflow.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42020/35980

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mseidel42 (Markus Seidel) for master.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@menglu21
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b877f3/33264/summary.html
COMMIT: 4f84c8a
CMSSW: CMSSW_13_2_X_2023-06-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42020/33264/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197958
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197927
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@perrotta @rappoccio this PR is also needed by cms-sw/cmsdist#8552

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 21, 2023

@cms-sw/generators-l2 can you please review/sign this? The pythia8 309 has already been merged without this PR and now IBs are broken.

@smuzaffar
Copy link
Contributor

@perrotta @rappoccio for now I have stopped building 11h00 IB for 13.2.X ( as it will be broken without this PR). Once it is merged then I will trigger the build for 13.2.X IB

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c06c3ee into cms-sw:master Jun 21, 2023
@rappoccio
Copy link
Contributor

  • Bypassing generators signature to fix the IBs, this was supposed to be merged along with the new Pythia version (my fault, apologies!)

vslokenb added a commit to vslokenb/cmssw that referenced this pull request Sep 20, 2023
PowhegHooksVincia removed because of potential error with PR cms-sw#42020, however this commit exactly copies the file from the 13_1 backport. Hopefully this remedies the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants