-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Powheg+Vincia matching" #42020
Conversation
This reverts commit 1c80a7d.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42020/35980
|
A new Pull Request was created by @mseidel42 (Markus Seidel) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b877f3/33264/summary.html Comparison SummarySummary:
|
@perrotta @rappoccio this PR is also needed by cms-sw/cmsdist#8552 |
@cms-sw/generators-l2 can you please review/sign this? The pythia8 309 has already been merged without this PR and now IBs are broken. |
@perrotta @rappoccio for now I have stopped building 11h00 IB for 13.2.X ( as it will be broken without this PR). Once it is merged then I will trigger the build for 13.2.X IB |
+1 |
merge |
|
PowhegHooksVincia removed because of potential error with PR cms-sw#42020, however this commit exactly copies the file from the 13_1 backport. Hopefully this remedies the issue
This reverts commit 1c80a7d.
PR description:
Not needed anymore for Pythia 8.309:
cms-sw/cmsdist#8552
PR validation:
Compiles, should not affect any workflow.