substained egg limit bypass #6017
Labels
Bug
Admin events aren't bugs
Comments
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 12, 2024
# About the pull request This PR fixes a couple bugs with xeno eggs and also adds a mechanic where eggs that have lost their weeds will become fragile. These eggs use the `CARRIER_EGG_MAXIMUM_LIFE` value (5 mins) but will convert back to normal eggs if their hive weeds are restored. If this doesn't discourage the weird behavior of placing and destroying pylons, we can just entirely remove the logic that restores the eggs to normal eggs. For fixes, there was a check on egg/click that prevented egg interaction if you weren't close or are a ghost, but it needed to first call parent first for examine logic. Then there was an issue where the timer for egg carrier eggs would get deleted if called the Burst proc (but it failed to check if the burst was from just someone retrieving the hugger) Forsaken variants of the new eggs will last indefinitely. # Explain why it's good for the game - Fixes #7405 - Fixes #6017 - Fixes being unable to examine eggs unless 1 tile away from them. Right now its possible to make eggs even on semi-weedable surfaces. This PR still allows this but they will only last 5 minutes if they don't have their weeds restored in time. In general I am okay with xenos creating traps for marines to get hugged, but doing so through weird mechanics like cycling a pylon construction needs to be discouraged. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://youtu.be/Hbyk6OikyjU </details> # Changelog :cl: Drathek balance: Eggs that lose their hive weeds will now turn fragile (like egg carrier eggs) lasting 5 minutes. fix: Fixed an exploit allowing egg carrier eggs to last indefinitely. fix: Fixed the inability to examine planted eggs from further than one tile. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Testmerges
#5763: 'Map: Bigred change south lambda padlock and turned it into a checkpoint.' by Huffie56 at commit 646c477 #5006: 'Project ARES: Added Tech Unlock logs' by realforest2001 at commit 1f2b803 #5401: 'M540-A Armored Recon Carrier' by Zonespace27 at commit 9aae279 #5938: 'Adds shockwaves to explosions' by GrrrKitten at commit 8dba9ad #5974: 'A more breakable Kutjevo' by spartanbobby at commit 02131e9 #5774: 'Updated XM43E1 for Sniper Spec' by Kaga-404 at commit 6c68c61 #6013: 'Autocompressor Efficiency Increase mk2' by Katskan at commit c8bc77a
Round ID
21477
Description of the bug
you can bypass substained egg limit by opening eggs that are placed on normal weeds
What's the difference with what should have happened?
the egg should be disconected unly after the egg is compleaty removed or if the hugger comes back in it gets counted to limit again
How do we reproduce this bug?
1.place eggs on normal weeds
2.open the eggs and let huggers go back in
3.you have eggs off weed and no substained eggs
...
Issue Bingo
The text was updated successfully, but these errors were encountered: