-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] add content/es/auto_scaling.md #1138
Conversation
* site configuration * update markdown format
* site configuration * update markdown format
Update dev-zh branch with main branch
* add content/zh/cloud_computing.md and container.md localization to zh
[zh] Add 10 .md localizations
[zh] localize virtual_machine.md & virtualization.md
localize container-image.md and continous_delivery.md
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dejo unas observaciones mínimas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solo una pequeña sugestión
@gamba47 Creo que los dos últimos commits no fueron firmados, ¿los podrías arreglar por favor? |
Uhhh pero no los firma si lo hago directamente desde github? nunca entre a mi consola, fue solamente presionar el boton "Sign off and commit suggestion" |
Se supone que sí los debió firmar, tal vez hubo un error que en este momento no identifico. Pero puedes arreglar los commits en tu local y subir éstos reescribiendo los anteriores. |
Co-authored-by: Victor Morales <chipahuac@hotmail.com> Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com> Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Solucionado! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Se cierra porque al cambiar de branch la cantidad de archivos por mergear esta mal. |
Fix #836 thanks to @ramrodo!