Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES] add content/es/auto_scaling.md #1138

Closed
wants to merge 216 commits into from
Closed

[ES] add content/es/auto_scaling.md #1138

wants to merge 216 commits into from

Conversation

gamba47
Copy link
Contributor

@gamba47 gamba47 commented Jul 29, 2022

Fix #836 thanks to @ramrodo!

hanyuancheung and others added 30 commits February 27, 2022 18:25
* site configuration

* update markdown format
* site configuration

* update markdown format
Update dev-zh branch with main branch
* add content/zh/cloud_computing.md and container.md localization to zh
[zh] Add 10 .md localizations
[zh] localize virtual_machine.md & virtualization.md
localize container-image.md and continous_delivery.md
gamba47 added 2 commits July 29, 2022 15:39
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
(cherry picked from commit aca82d9)
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
(cherry picked from commit c084839)
@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit ccd46f1
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/62f7d24d87e35d000957d9ca
😎 Deploy Preview https://deploy-preview-1138--cncfglossary.netlify.app/es/auto-scaling
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo added the lang/es for Spanish label Jul 30, 2022
@jihoon-seo jihoon-seo linked an issue Jul 30, 2022 that may be closed by this pull request
Copy link
Collaborator

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejo unas observaciones mínimas

content/es/auto-scaling.md Outdated Show resolved Hide resolved
content/es/auto-scaling.md Outdated Show resolved Hide resolved
content/es/auto-scaling.md Show resolved Hide resolved
content/es/auto-scaling.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo una pequeña sugestión

@ramrodo
Copy link
Collaborator

ramrodo commented Aug 10, 2022

@gamba47 Creo que los dos últimos commits no fueron firmados, ¿los podrías arreglar por favor?

@gamba47
Copy link
Contributor Author

gamba47 commented Aug 10, 2022

@gamba47 Creo que los dos últimos commits no fueron firmados, ¿los podrías arreglar por favor?

Uhhh pero no los firma si lo hago directamente desde github? nunca entre a mi consola, fue solamente presionar el boton "Sign off and commit suggestion"

@ramrodo
Copy link
Collaborator

ramrodo commented Aug 10, 2022

Uhhh pero no los firma si lo hago directamente desde github? nunca entre a mi consola, fue solamente presionar el boton "Sign off and commit suggestion"

Se supone que sí los debió firmar, tal vez hubo un error que en este momento no identifico.

Pero puedes arreglar los commits en tu local y subir éstos reescribiendo los anteriores.

gamba47 and others added 2 commits August 13, 2022 13:32
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
Co-authored-by: Rodolfo Martínez Vega <rodomar@outlook.com>
Signed-off-by: Emiliano <emilianovazquez@gmail.com>
@gamba47
Copy link
Contributor Author

gamba47 commented Aug 13, 2022

@gamba47 Creo que los dos últimos commits no fueron firmados, ¿los podrías arreglar por favor?

Solucionado!

Copy link
Collaborator

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@electrocucaracha electrocucaracha changed the base branch from main to dev-es August 15, 2022 16:58
@gamba47
Copy link
Contributor Author

gamba47 commented Aug 16, 2022

Se cierra porque al cambiar de branch la cantidad de archivos por mergear esta mal.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/es for Spanish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spanish] localize 'Autoscaling'