Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dev-ko into main (for Korean localization live version) #1333

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Merge dev-ko into main (for Korean localization live version) #1333

merged 5 commits into from
Sep 26, 2022

Conversation

yunkon-kim
Copy link
Collaborator

Describe your changes

Merge dev-ko into main branch

  • Disable TEMPLATE in the Korean site sidebar
  • Add 2 new localized terms

Related issue number or link (ex: resolves #issue-number)

N/A

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO.

seokho-son and others added 5 commits September 13, 2022 21:55
@seokho-son @bconfiden2 @jihoon-seo
Translate abstraction.md into Korean (#1276)
cecd0c5 
Co-authored-by: bconfiden2 <bconfiden2@naver.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
@seokho-son
Merge pull request #1312 from cncf/main
59d4c91 
Update dev-ko branch by merging main branch
@SeolRoh @yunkon-kim
[ko]Translate 'Idempotence' in Korean (#1294)
370dd2b 
* Update content/ko/idempotence.md

Signed-off-by: rohseol <seven800@naver.com>
Signed-off-by: 노설 <34231229+SeolRoh@users.noreply.github.com>
Co-authored-by: Yunkon Kim  <7975459+yunkon-kim@users.noreply.github.com>
@seokho-son
Merge pull request #1330 from cncf/main
ab1dcd2 
Update dev-ko with main branch
@seokho-son @jihoon-seo
Disable TEMPLATE from sidebar of Korean site (#1328)
6c1e95e 
Signed-off-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Sep 25, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 6c1e95e
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6330719682ae3900082aefc8
😎 Deploy Preview https://deploy-preview-1333--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jihoon-seo
jihoon-seo approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다!

seokho-son
seokho-son approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@seokho-son seokho-son merged commit 84a8d9f into main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo approved these changes

@seokho-son seokho-son seokho-son approved these changes

@Eviekim Eviekim Awaiting requested review from Eviekim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunkon-kim @seokho-son @jihoon-seo @SeolRoh