Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev-es branch with main branch #692

Merged
merged 49 commits into from
Apr 8, 2022

Conversation

electrocucaracha
Copy link
Collaborator

Apparently, the use of Merge pull request option difficult the rebase process, resulting in cherry-picking changes and the recreation of dev-es branch. One possible solution for keeping a linear project history in the long-running dev-es branch could be the use of Squash and merge option

seokho-son and others added 30 commits February 3, 2022 01:40
* Create abstraction.md

* Update content/hi/abstraction.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* Update content/hi/abstraction.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* Update abstraction.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
* Update config.toml

* Update config.toml

* Update config.toml

* add TEMPLATE and _index.md

* Create _index.md

* Update _index.md

* Update _index.md

* Create hi.toml

* Update config.toml

* Update hi.toml

* Update _TEMPLATE.md

* Create _index.md

* Create cloud_native_tech.md

* Update _index.md
* create containerization.md

Signed-off-by: Kunal Verma <vkunal321@gmail.com>

* Update content/hi/containerization.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* Update content/hi/containerization.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* Update content/hi/containerization.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Kunal Verma <vkunal321@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
* update

Signed-off-by: shivam tyagi <shivamt.ug19.ec@nitp.ac.in>

* Update content/hi/auto_scaling.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* Update content/hi/auto_scaling.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* Update content/hi/auto_scaling.md

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
* [hi] localize continuous_integration.md

* [hi] localize continuous_integration.md(modified)

* [hi] localize continuous_integration.md(modified)

* [hi] localize continuous_integration.md(modified)
* Localize container-image.md

* replace इमेजिस with इमेजें/ इमेजों as suitable

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* fix : transliterate terms

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

* fix: transliterate static, execute

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>

Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Dipankar Das <dipsonu10@hotmail.com>
* Update dev-ar approver

* Update dev-es approvers

* Fix l10n approvers list
remove `?originalSubdomain=in` from linkedin

Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
krol3 and others added 3 commits April 4, 2022 16:35
* feat: spanish abstraction
* revision: es abtraction

Co-authored-by: carolina valencia <krol3@users.noreply.github.com>
Co-authored-by: Victor Morales <chipahuac@hotmail.com>
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit c1f3b0c
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/624b81a093bba80008255927
😎 Deploy Preview https://deploy-preview-692--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo jihoon-seo added the maintainers Use this label if PR requires maintainers to take action label Apr 5, 2022
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@electrocucaracha electrocucaracha requested a review from krol3 April 7, 2022 01:57
Copy link
Collaborator

@krol3 krol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seokho-son
Copy link
Collaborator

Hi @electrocucaracha :)
The PR LGTM.

I am trying to understand your comment. :)

Apparently, the use of Merge pull request option difficult the rebase process, resulting in cherry-picking changes and the recreation of dev-es branch. One possible solution for keeping a linear project history in the long-running dev-es branch could be the use of Squash and merge option

Do you want Squash and merge for this PR ?

I think these are a way to minimize conflicts.

  1. in dev-es branch, focus on content/es/* and try to avoid changing files outside content/es/
  • except config.toml for the first round of localization.
  1. in main branch, avoid changing files in content/es/

If we can minimize conflicts, we might rebase the branch simply without cherry-picking changes. (I think)

@electrocucaracha
Copy link
Collaborator Author

electrocucaracha commented Apr 7, 2022

@seokho-son my main problem was with individual translations (PRs to dev-es branch) which were merged with Merge pull request option, this is resulting in a multiple branches in history.

Let's take the PR #641 as an example. After the Merge pull request option was selected, the history looks like this.

flowchart TB
    subgraph main
        . --> 8933ae6 --> 1a46bee --> 96dcc01 --> ..
    end
    subgraph dev-es
        96dcc01 --> a9e784d --> d78bb81 --> 11fd690 --> ...
    end
    subgraph PR-641
        11fd690 --> c9a080d --> d669f8b --> b391f36
    end
Loading

So what I suggest for this kind of changes is to chose Squash and mergeoption to keep a linear history like this

flowchart TB
    subgraph main
        . --> 8933ae6 --> 1a46bee --> 96dcc01 --> ..
    end
    subgraph dev-es
        96dcc01 --> a9e784d --> d78bb81 --> 11fd690 --> PR-641
    end
Loading

For this PR, I'm not sure if the Merge pull request option or Rebase and merge option are correct, but definitely not the Squash and merge option.

@seokho-son
Copy link
Collaborator

@electrocucaracha

oh :)

I strongly agree with using "squash and merge" for individual PRs to dev-es branch.
It is the recommendation from maintainers as well :)

  • Branch management: using a proper merge methods
    • For glossary approvers and maintainers

      • In case of general PRs like new term or update term
        • Please use Squash and merge
      • the other cases: approvers need to select an appropriate method
        • Ex: use Create a merge commit when we handle commits in different branches
    • For l10n approvers

      • L10n PRs
        • Please use Squash and merge

@seokho-son seokho-son merged commit e656999 into cncf:dev-es Apr 8, 2022
@electrocucaracha electrocucaracha deleted the dev-es branch April 8, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/es for Spanish maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.