Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs: remove the deprecated mixed 20.1/20.2 code paths #54251

Closed
knz opened this issue Sep 11, 2020 · 1 comment · Fixed by #61417
Closed

jobs: remove the deprecated mixed 20.1/20.2 code paths #54251

knz opened this issue Sep 11, 2020 · 1 comment · Fixed by #61417
Assignees
@ajwerner
Labels
A-jobs C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. X-anchored-telemetry The issue number is anchored by telemetry references.

Comments

@knz
Copy link
Contributor

knz commented Sep 11, 2020

There are "deprecated" functions that refer to this issue (X-anchored-telemetry).

This code should be removed and then this issue closed.
@knz knz added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. X-anchored-telemetry The issue number is anchored by telemetry references. A-jobs labels Sep 11, 2020
@knz knz mentioned this issue Sep 11, 2020
Merged
craig bot pushed a commit that referenced this issue Sep 14, 2020
@knz
Merge #54256
40f03d9 
54256: sql: make multi-tenancy errors report to telemetry r=asubiotto a=knz

Fixes #48164. 

Issues referenced, I also added the X-anchored-telemetry label to them on github (we keep those issues open on github until their reference in the code is removed):

#54254 
#54255 
#54250 
#54251 
#54252 
#49854 
#48274
#47150
#47971
#47970
#47900 
#47925 


Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@ajwerner ajwerner mentioned this issue Mar 3, 2021
Merged
@ajwerner
Copy link
Contributor

It got too late in 21.1 to do this. We'll merge the WIP PR for 21.2.

@ajwerner ajwerner mentioned this issue Mar 31, 2021
Closed
@craig craig bot closed this as completed in 0048669 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
A-jobs C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. X-anchored-telemetry The issue number is anchored by telemetry references.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jobs: remove deprecated 20.1/20.2 migration code ajwerner/cockroach
2 participants
@knz @ajwerner