sql: make multi-tenancy errors report to telemetry #54256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, 5 of 5 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @knz, @nvanbenschoten, @spaskob, and @tbg)
pkg/util/errorutil/tenant_deprecated_wrapper.go, line 84 at r1 (raw file):
} // FeatureNotAvailableToNonSystemTenantsIssue is to be used with the Optinal
nit: s/Optinal/Optional
There was an issue number missing in a few places, because the argument list made it optional. This patch fixes it and links too the relevant issues. Release note: None
This change ensures that multitenancy errors get collected in telemetry. By also making the issue number non-optional, this patch also catches a few more cases that were missing open issues. Release note: None
knz
commented
Sep 14, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/util/errorutil/tenant_deprecated_wrapper.go, line 84 at r1 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
nit:
s/Optinal/Optional
Done.
knz
force-pushed
the
20200911-err-multitenant
branch
from
de5680f
to
3fcafa8
Compare
|
TFYR! bors r=asubiotto |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48164.
Issues referenced, I also added the X-anchored-telemetry label to them on github (we keep those issues open on github until their reference in the code is removed):
#54254
#54255
#54250
#54251
#54252
#49854
#48274
#47150
#47971
#47970
#47900
#47925