Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: this feature is not available under multi-tenancy #54252

Open
7 of 21 tasks
knz opened this issue Sep 11, 2020 · 2 comments
Open
7 of 21 tasks

sql: this feature is not available under multi-tenancy #54252

knz opened this issue Sep 11, 2020 · 2 comments
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-db-server X-anchored-telemetry The issue number is anchored by telemetry references.

Comments

@knz
Copy link
Contributor

knz commented Sep 11, 2020 •
edited by exalate-issue-sync bot
Loading

This issue is a placeholder for SQL features that are not valid for non-system tenants (when multi-tenancy is active).

The list of features not available to non-system tenants includes:

Virtual tables:

  • crdb_internal.gossip_alerts
  • crdb_internal.gossip_liveness
  • crdb_internal.gossip_nodes
  • crdb_internal.kv_flow_controller
  • crdb_internal.kv_flow_control_handles
  • crdb_internal.kv_flow_token_deductions
  • crdb_internal.kv_node_status
  • crdb_internal.kv_node_liveness
  • crdb_internal.kv_store_status
  • crdb_internal.node_tenant_capabilities_cache
  • crdb_internal.tenant_usage_details
  • (20.2) crdb_internal.node_transactions done
  • (20.2) crdb_internal.cluster_transactions done
  • (20.2) crdb_internal.node_queries done
  • (20.2) crdb_internal.cluster_queries done
  • (20.2) crdb_internal.node_sessions done
  • (20.2) crdb_internal.cluster_sessions done
  • crdb_internal.check_consistency() done

Builtins:

  • crdb_internal.kv_enqueue_replica
  • crdb_internal.kv_set_queue_active
  • crdb_internal.probe_ranges

Note: this issue is referenced from error messages. The description of the issue should be extended with suggestions on what to do when the error is encountered.

Jira issue: CRDB-3779

Epic CRDB-39092
@blathers-crl blathers-crl bot added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 11, 2020
@knz knz added X-anchored-telemetry The issue number is anchored by telemetry references. A-multitenancy Related to multi-tenancy labels Sep 11, 2020
@knz knz mentioned this issue Sep 11, 2020
Merged
craig bot pushed a commit that referenced this issue Sep 14, 2020
@knz
Merge #54256
40f03d9 
54256: sql: make multi-tenancy errors report to telemetry r=asubiotto a=knz

Fixes #48164. 

Issues referenced, I also added the X-anchored-telemetry label to them on github (we keep those issues open on github until their reference in the code is removed):

#54254 
#54255 
#54250 
#54251 
#54252 
#49854 
#48274
#47150
#47971
#47970
#47900 
#47925 


Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@otan otan mentioned this issue May 14, 2021
Closed
@cockroachdb cockroachdb deleted a comment from blathers-crl bot Nov 11, 2021
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jan 10, 2023
@ecwall ecwall mentioned this issue Mar 22, 2023
Closed
@knz knz mentioned this issue Apr 6, 2023
Open
@yuzefovich yuzefovich assigned yuzefovich and unassigned ecwall May 16, 2023
@yuzefovich
Copy link
Member

@yuzefovich to audit the code to see whether any more stuff is missing from the list above.

@yuzefovich yuzefovich mentioned this issue Jun 13, 2023
Merged
craig bot pushed a commit that referenced this issue Jun 13, 2023
@fqazi @yuzefovich @andyyang890
Merge #104641 #104803 #104809
002c193 
104641: cli/doctor: address issues in the debug doctor command r=fqazi a=fqazi

Previously, the debug doctor had the following issues on master:

1. Running the 23.1 / master doctor against older cluster versions would run into issues with the jobs tables since we started using a new crdb_internal table to get a similar view
2. Quoted table names in a zip directory were not unescaped properly, which could lead to validation errors
3. Added support for JSON based zipdirs which are the default on master

104803: backupccl: break dependency on gossip r=yuzefovich a=yuzefovich

This commit removes the dependency of the backup / restore on gossip. Previously, gossip was used to count the number of nodes in the cluster, and this information is used for telemetry reporting as well as for chunking up the working spans. However, that seems unnecessary and in some cases incorrect.

In particular, for backup telemetry we computed speed per node via dividing by the cluster node count, but we might have used less SQL instances, so we should actually be dividing by the number of SQL instances used in the backup plan. In restore we use all available SQL instances, and we now calculate that number right before using it for telemetry calculation. It's possible that we used different number of instances in the restore operations (which there appear to be three) when the instances went up or down, but it's probably not that important.

Addresses: #54252.
Epic: None.

Release note: None

104809: sql/pgwire: deflake TestAuthenticationAndHBARules r=rafiss a=andyyang890

This patch deflakes pgwire.TestAuthenticationAndHBARules by adding
more `authlog` directives. Without an `authlog` after each connection
attempt, there is non-determinism in the ordering of the logs.

Fixes #104381
Fixes #100353

Release note: None

Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Andy Yang <yang@cockroachlabs.com>
@knz
Copy link
Contributor Author

knz commented Jun 15, 2023

I found this:

pkg > kv > kvserver > kvserverbase > stores.go, (i UnsupportedStoresIterator) ForEachStore()

In general any SQL feature that depends on inspecting KV-level stores should use a KV RPC instead of accessing the store iterator directly.

@yuzefovich yuzefovich removed their assignment Jan 4, 2024
@rimadeodhar rimadeodhar added T-db-server and removed T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-db-server X-anchored-telemetry The issue number is anchored by telemetry references.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knz @yuzefovich @ecwall @rimadeodhar